Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2241413002: Refactor out reusable pieces from new Botlist (Closed)

Created:
4 years, 4 months ago by kjlubick
Modified:
4 years, 4 months ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Refactor out reusable pieces from new Botlist I will be able to use these in the new Tasklist. This does not impact features or look at all. BUG=631047 Committed: https://github.com/luci/luci-py/commit/1001b648ed479be12acb974acd812faf879b2342

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+512 lines, -355 lines) Patch
M appengine/swarming/elements/build/elements.html View 19 chunks +219 lines, -177 lines 0 comments Download
M appengine/swarming/elements/res/imp/botlist/bot-list.html View 15 chunks +34 lines, -158 lines 2 comments Download
M appengine/swarming/elements/res/imp/botlist/bot-list-data.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/res/imp/botlist/bot-list-shared.html View 4 chunks +5 lines, -18 lines 0 comments Download
A appengine/swarming/elements/res/imp/common/dynamic-table.html View 1 1 chunk +219 lines, -0 lines 0 comments Download
M appengine/swarming/elements/res/imp/common/swarming-app.html View 1 2 chunks +34 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
kjlubick
4 years, 4 months ago (2016-08-15 19:17:48 UTC) #3
jcgregorio
https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements/res/imp/common/dynamic-table.html File appengine/swarming/elements/res/imp/common/dynamic-table.html (right): https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements/res/imp/common/dynamic-table.html#newcode6 appengine/swarming/elements/res/imp/common/dynamic-table.html:6: This file contains most of the logic needed to ...
4 years, 4 months ago (2016-08-16 12:09:27 UTC) #4
kjlubick
https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements/res/imp/common/dynamic-table.html File appengine/swarming/elements/res/imp/common/dynamic-table.html (right): https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements/res/imp/common/dynamic-table.html#newcode6 appengine/swarming/elements/res/imp/common/dynamic-table.html:6: This file contains most of the logic needed to ...
4 years, 4 months ago (2016-08-16 12:29:46 UTC) #5
jcgregorio
lgtm
4 years, 4 months ago (2016-08-16 12:44:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241413002/20001
4 years, 4 months ago (2016-08-16 13:26:41 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-16 13:26:43 UTC) #10
KevinL
lgtm
4 years, 4 months ago (2016-08-16 13:26:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241413002/20001
4 years, 4 months ago (2016-08-16 13:27:13 UTC) #14
stephana
https://codereview.chromium.org/2241413002/diff/20001/appengine/swarming/elements/res/imp/botlist/bot-list.html File appengine/swarming/elements/res/imp/botlist/bot-list.html (right): https://codereview.chromium.org/2241413002/diff/20001/appengine/swarming/elements/res/imp/botlist/bot-list.html#newcode372 appengine/swarming/elements/res/imp/botlist/bot-list.html:372: value: function() { This will always return the same ...
4 years, 4 months ago (2016-08-16 13:28:06 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://github.com/luci/luci-py/commit/1001b648ed479be12acb974acd812faf879b2342
4 years, 4 months ago (2016-08-16 13:30:17 UTC) #17
kjlubick
4 years, 4 months ago (2016-08-16 13:41:25 UTC) #18
Message was sent while issue was closed.
https://codereview.chromium.org/2241413002/diff/20001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/bot-list.html (right):

https://codereview.chromium.org/2241413002/diff/20001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/bot-list.html:372: value: function()
{
On 2016/08/16 at 13:28:06, stephana wrote:
> This will always return the same reference to specialColumns, which might be
what you want. In that case you should not need to wrap it in a function, IMO.

Good call, will address on next CL.

Powered by Google App Engine
This is Rietveld 408576698