Refactor out reusable pieces from new Botlist

Refactor out reusable pieces from new Botlist

I will be able to use these in the new Tasklist.  This does not impact features or look at all.

BUG=631047
Committed: https://github.com/luci/luci-py/commit/1001b648ed479be12acb974acd812faf879b2342

[kjlubick, 2016-08-15 19:03:51]

Description was changed from

==========
Refactor out reusable pieces from new Botlist

I will be able to use these in the new Tasklist

BUG=631047
==========

to

==========
Refactor out reusable pieces from new Botlist

I will be able to use these in the new Tasklist.  This does not impact features
or look at all.

BUG=631047
==========

[kjlubick, 2016-08-15 19:03:51]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[jcgregorio, 2016-08-16 12:09:27]

https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements...
File appengine/swarming/elements/res/imp/common/dynamic-table.html (right):

https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/common/dynamic-table.html:6: This file
contains most of the logic needed to create a dynamic table. It is roken up into
two parts, a style dom-module called "dynamic-table-style" and a behavior called
SwarmingBehaviors.DynamicTableBehavior. This behavior ties together filtering,
sorting and column content. It also offers a few utilities to make creating the
table easier. A client of these two parts needs to create the templates to
actually draw the <table>,<tr> and so on.  See bot-list.html and task-list.html
for examples.
Line wrap at 100 chars. Also check other lines below.

Also:
  roken->broken

https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/common/dynamic-table.html:188:
this.set("_sortstr", e.detail.name +":"+e.detail.direction);
Spaces around plus:

+ ":" + e.

https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/common/dynamic-table.html:194: return
this._columns.filter(function(c){
function(c) {

https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements...
File appengine/swarming/elements/res/imp/common/swarming-app.html (right):

https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/common/swarming-app.html:163: // can't use
.foreach, as arguments isn't really a function.
isn't really an Array.

[kjlubick, 2016-08-16 12:29:46]

https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements...
File appengine/swarming/elements/res/imp/common/dynamic-table.html (right):

https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/common/dynamic-table.html:6: This file
contains most of the logic needed to create a dynamic table. It is roken up into
two parts, a style dom-module called "dynamic-table-style" and a behavior called
SwarmingBehaviors.DynamicTableBehavior. This behavior ties together filtering,
sorting and column content. It also offers a few utilities to make creating the
table easier. A client of these two parts needs to create the templates to
actually draw the <table>,<tr> and so on.  See bot-list.html and task-list.html
for examples.
On 2016/08/16 at 12:09:27, jcgregorio wrote:
> Line wrap at 100 chars. Also check other lines below.
> 
> Also:
>   roken->broken

Whoops, forgot to do this.  Done.

https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/common/dynamic-table.html:188:
this.set("_sortstr", e.detail.name +":"+e.detail.direction);
On 2016/08/16 at 12:09:27, jcgregorio wrote:
> Spaces around plus:
> 
> + ":" + e.

Done.

https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/common/dynamic-table.html:194: return
this._columns.filter(function(c){
On 2016/08/16 at 12:09:27, jcgregorio wrote:
> function(c) {

Done.

https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements...
File appengine/swarming/elements/res/imp/common/swarming-app.html (right):

https://codereview.chromium.org/2241413002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/common/swarming-app.html:163: // can't use
.foreach, as arguments isn't really a function.
On 2016/08/16 at 12:09:27, jcgregorio wrote:
> isn't really an Array.

Fixed.

[jcgregorio, 2016-08-16 12:44:41]

lgtm

[kjlubick, 2016-08-16 13:26:39]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2016-08-16 13:26:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 13:26:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 13:26:43]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[KevinL, 2016-08-16 13:26:58]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-08-16 13:26:59]

lgtm

[KevinL, 2016-08-16 13:27:01]

The CQ bit was checked by kjlubick@chromium.org

[commit-bot: I haz the power, 2016-08-16 13:27:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stephana, 2016-08-16 13:28:06]

https://codereview.chromium.org/2241413002/diff/20001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/bot-list.html (right):

https://codereview.chromium.org/2241413002/diff/20001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/bot-list.html:372: value: function()
{
This will always return the same reference to specialColumns, which might be
what you want. In that case you should not need to wrap it in a function, IMO.

[commit-bot: I haz the power, 2016-08-16 13:30:16]

Description was changed from

==========
Refactor out reusable pieces from new Botlist

I will be able to use these in the new Tasklist.  This does not impact features
or look at all.

BUG=631047
==========

to

==========
Refactor out reusable pieces from new Botlist

I will be able to use these in the new Tasklist.  This does not impact features
or look at all.

BUG=631047

Committed:
https://github.com/luci/luci-py/commit/1001b648ed479be12acb974acd812faf879b2342
==========

[commit-bot: I haz the power, 2016-08-16 13:30:17]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/1001b648ed479be12acb974acd812faf879b2342

[kjlubick, 2016-08-16 13:41:25]

https://codereview.chromium.org/2241413002/diff/20001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botlist/bot-list.html (right):

https://codereview.chromium.org/2241413002/diff/20001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botlist/bot-list.html:372: value: function()
{
On 2016/08/16 at 13:28:06, stephana wrote:
> This will always return the same reference to specialColumns, which might be
what you want. In that case you should not need to wrap it in a function, IMO.

Good call, will address on next CL.