Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils.cc

Issue 2241393003: Offline Pages: Add custom tabs namespace to tab helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Generalize to allow all namespaces. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/offline_page_utils.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_utils.cc b/chrome/browser/android/offline_pages/offline_page_utils.cc
index a607b43420b10a7f1d6a0a39b35f8c3f53adde1a..c12186d9ecc04106772a5a7a640a3bede7542222 100644
--- a/chrome/browser/android/offline_pages/offline_page_utils.cc
+++ b/chrome/browser/android/offline_pages/offline_page_utils.cc
@@ -64,10 +64,8 @@ void OnGetPagesByOnlineURLDone(
const OfflinePageItem* selected_page = nullptr;
std::string tab_id_str = base::IntToString(tab_id);
for (const auto& offline_page : pages) {
- if ((offline_page.client_id.name_space == kBookmarkNamespace) ||
- (offline_page.client_id.name_space == kAsyncNamespace) ||
- (offline_page.client_id.name_space == kLastNNamespace &&
- offline_page.client_id.id == tab_id_str)) {
+ if (offline_page.client_id.name_space != kLastNNamespace ||
+ offline_page.client_id.id == tab_id_str) {
if (!selected_page ||
offline_page.creation_time > selected_page->creation_time) {
selected_page = &offline_page;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698