Reland of Enable whitelist generation for official builds.

Reland of Enable whitelist generation for official builds.

Previous: https://codereview.chromium.org/2175413004/

Currently, all resources are included in PAK files when Chrome is
built locally. Only official_buildbot.sh uses a resource whitelist. This CL
enables local builds to use resource whitelisting by setting the
enable_resource_whitelist_generation gn flag to true, or by building an
official build.

This will allow developers to more easily monitor the changes in APK size
for each commit they make.

However, a large amount of output is generated (_pragma is used to
create warnings to allow whitelisted resources to be listed), so for now
the whitelist will only be generated for official builds.

This change results in a ~1.5 mb difference when calculating the APK size with resource_sizes.py.

BUG=632385
Committed: https://crrev.com/e19e7089b508c4c6d6d9ea022068e2ee93a68490
Cr-Commit-Position: refs/heads/master@{#413584}

[estevenson, 2016-08-16 14:22:38]

Description was changed from

==========
Enable whitelist generation for official builds.

Currently, all resources are included in PAK files when Chrome is
built locally. Only official_buildbot.sh uses a resource whitelist. This CL
enables local builds to use resource whitelisting by setting the
enable_resource_whitelist_generation gn flag to true, or by building an
official build.

This will allow developers to more easily monitor the changes in APK size
for each commit they make.

However, a large amount of output is generated (_pragma is used to
create warnings to allow whitelisted resources to be listed), so for now
the whitelist will only be generated for official builds.

Comparison of ChromePublic.apk_InstallSize APK size using resource_sizes.py:
* with enable_resource_whitelist_generation: 74123587 bytes
* without enable_resource_whitelist_generation: 75824903 bytes

BUG=632385
==========

to

==========
Enable whitelist generation for official builds.

Currently, all resources are included in PAK files when Chrome is
built locally. Only official_buildbot.sh uses a resource whitelist. This CL
enables local builds to use resource whitelisting by setting the
enable_resource_whitelist_generation gn flag to true, or by building an
official build.

This will allow developers to more easily monitor the changes in APK size
for each commit they make.

However, a large amount of output is generated (_pragma is used to
create warnings to allow whitelisted resources to be listed), so for now
the whitelist will only be generated for official builds.

Comparison of ChromePublic.apk_InstallSize APK size using resource_sizes.py:
* with enable_resource_whitelist_generation: 74123587 bytes
* without enable_resource_whitelist_generation: 75824903 bytes

BUG=632385
==========

[estevenson, 2016-08-16 14:31:34]

Description was changed from

==========
Enable whitelist generation for official builds.

Currently, all resources are included in PAK files when Chrome is
built locally. Only official_buildbot.sh uses a resource whitelist. This CL
enables local builds to use resource whitelisting by setting the
enable_resource_whitelist_generation gn flag to true, or by building an
official build.

This will allow developers to more easily monitor the changes in APK size
for each commit they make.

However, a large amount of output is generated (_pragma is used to
create warnings to allow whitelisted resources to be listed), so for now
the whitelist will only be generated for official builds.

Comparison of ChromePublic.apk_InstallSize APK size using resource_sizes.py:
* with enable_resource_whitelist_generation: 74123587 bytes
* without enable_resource_whitelist_generation: 75824903 bytes

BUG=632385
==========

to

==========
Reland of Enable whitelist generation for official builds.

Previous: https://codereview.chromium.org/2175413004/

Currently, all resources are included in PAK files when Chrome is
built locally. Only official_buildbot.sh uses a resource whitelist. This CL
enables local builds to use resource whitelisting by setting the
enable_resource_whitelist_generation gn flag to true, or by building an
official build.

This will allow developers to more easily monitor the changes in APK size
for each commit they make.

However, a large amount of output is generated (_pragma is used to
create warnings to allow whitelisted resources to be listed), so for now
the whitelist will only be generated for official builds.

Comparison of ChromePublic.apk_InstallSize APK size using resource_sizes.py:
* with enable_resource_whitelist_generation: 74123587 bytes
* without enable_resource_whitelist_generation: 75824903 bytes

BUG=632385
==========

[estevenson, 2016-08-16 14:34:18]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org, dpranke@chromium.org

[estevenson, 2016-08-16 14:34:19]

ptal, the only change here is that the output directory for the resource
whitelist is changed to root_gen_dir (I had problems with some internal targets
when trying to use target_gen_dir).

[Dirk Pranke, 2016-08-16 16:17:29]

lgtm

[agrieve, 2016-08-22 20:18:14]

lgtm with one nit

https://codereview.chromium.org/2241383004/diff/1/chrome/chrome_repack_locale...
File chrome/chrome_repack_locales.gni (right):

https://codereview.chromium.org/2241383004/diff/1/chrome/chrome_repack_locale...
chrome/chrome_repack_locales.gni:123: repack_whitelist =
"$root_gen_dir/resource_whitelist.txt"
I see - the problem would be if this .gni is imported by a file outside of
chome/, it will resolve differently than the one in chrome/BUILD.gn.

I think having "resource_whitelist.txt" in the root makes it a bit too
non-obvious what it is associated with. Other resource-related targets in
chrome/BUILD.gn use "$root_gen_dir/chrome/foo". So how about changing it to have
that extra subpath in there?

[estevenson, 2016-08-22 20:50:37]

Description was changed from

==========
Reland of Enable whitelist generation for official builds.

Previous: https://codereview.chromium.org/2175413004/

Currently, all resources are included in PAK files when Chrome is
built locally. Only official_buildbot.sh uses a resource whitelist. This CL
enables local builds to use resource whitelisting by setting the
enable_resource_whitelist_generation gn flag to true, or by building an
official build.

This will allow developers to more easily monitor the changes in APK size
for each commit they make.

However, a large amount of output is generated (_pragma is used to
create warnings to allow whitelisted resources to be listed), so for now
the whitelist will only be generated for official builds.

Comparison of ChromePublic.apk_InstallSize APK size using resource_sizes.py:
* with enable_resource_whitelist_generation: 74123587 bytes
* without enable_resource_whitelist_generation: 75824903 bytes

BUG=632385
==========

to

==========
Reland of Enable whitelist generation for official builds.

Previous: https://codereview.chromium.org/2175413004/

Currently, all resources are included in PAK files when Chrome is
built locally. Only official_buildbot.sh uses a resource whitelist. This CL
enables local builds to use resource whitelisting by setting the
enable_resource_whitelist_generation gn flag to true, or by building an
official build.

This will allow developers to more easily monitor the changes in APK size
for each commit they make.

However, a large amount of output is generated (_pragma is used to
create warnings to allow whitelisted resources to be listed), so for now
the whitelist will only be generated for official builds.

This change results in a ~1.5 mb difference when calculating the APK size with
resource_sizes.py.

BUG=632385
==========

[estevenson, 2016-08-22 20:50:55]

https://codereview.chromium.org/2241383004/diff/1/chrome/chrome_repack_locale...
File chrome/chrome_repack_locales.gni (right):

https://codereview.chromium.org/2241383004/diff/1/chrome/chrome_repack_locale...
chrome/chrome_repack_locales.gni:123: repack_whitelist =
"$root_gen_dir/resource_whitelist.txt"
On 2016/08/22 20:18:14, agrieve (OOO until aug 22) wrote:
> I see - the problem would be if this .gni is imported by a file outside of
> chome/, it will resolve differently than the one in chrome/BUILD.gn.
> 
> I think having "resource_whitelist.txt" in the root makes it a bit too
> non-obvious what it is associated with. Other resource-related targets in
> chrome/BUILD.gn use "$root_gen_dir/chrome/foo". So how about changing it to
have
> that extra subpath in there?

Done.

[estevenson, 2016-08-22 20:51:33]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2016-08-22 20:51:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2241383004/#ps20001
(title: "rebase + change whitelist file output directory")

[commit-bot: I haz the power, 2016-08-22 20:52:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 23:40:14]

Description was changed from

==========
Reland of Enable whitelist generation for official builds.

Previous: https://codereview.chromium.org/2175413004/

Currently, all resources are included in PAK files when Chrome is
built locally. Only official_buildbot.sh uses a resource whitelist. This CL
enables local builds to use resource whitelisting by setting the
enable_resource_whitelist_generation gn flag to true, or by building an
official build.

This will allow developers to more easily monitor the changes in APK size
for each commit they make.

However, a large amount of output is generated (_pragma is used to
create warnings to allow whitelisted resources to be listed), so for now
the whitelist will only be generated for official builds.

This change results in a ~1.5 mb difference when calculating the APK size with
resource_sizes.py.

BUG=632385
==========

to

==========
Reland of Enable whitelist generation for official builds.

Previous: https://codereview.chromium.org/2175413004/

Currently, all resources are included in PAK files when Chrome is
built locally. Only official_buildbot.sh uses a resource whitelist. This CL
enables local builds to use resource whitelisting by setting the
enable_resource_whitelist_generation gn flag to true, or by building an
official build.

This will allow developers to more easily monitor the changes in APK size
for each commit they make.

However, a large amount of output is generated (_pragma is used to
create warnings to allow whitelisted resources to be listed), so for now
the whitelist will only be generated for official builds.

This change results in a ~1.5 mb difference when calculating the APK size with
resource_sizes.py.

BUG=632385
==========

[commit-bot: I haz the power, 2016-08-22 23:40:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-22 23:43:09]

Description was changed from

==========
Reland of Enable whitelist generation for official builds.

Previous: https://codereview.chromium.org/2175413004/

Currently, all resources are included in PAK files when Chrome is
built locally. Only official_buildbot.sh uses a resource whitelist. This CL
enables local builds to use resource whitelisting by setting the
enable_resource_whitelist_generation gn flag to true, or by building an
official build.

This will allow developers to more easily monitor the changes in APK size
for each commit they make.

However, a large amount of output is generated (_pragma is used to
create warnings to allow whitelisted resources to be listed), so for now
the whitelist will only be generated for official builds.

This change results in a ~1.5 mb difference when calculating the APK size with
resource_sizes.py.

BUG=632385
==========

to

==========
Reland of Enable whitelist generation for official builds.

Previous: https://codereview.chromium.org/2175413004/

Currently, all resources are included in PAK files when Chrome is
built locally. Only official_buildbot.sh uses a resource whitelist. This CL
enables local builds to use resource whitelisting by setting the
enable_resource_whitelist_generation gn flag to true, or by building an
official build.

This will allow developers to more easily monitor the changes in APK size
for each commit they make.

However, a large amount of output is generated (_pragma is used to
create warnings to allow whitelisted resources to be listed), so for now
the whitelist will only be generated for official builds.

This change results in a ~1.5 mb difference when calculating the APK size with
resource_sizes.py.

BUG=632385

Committed: https://crrev.com/e19e7089b508c4c6d6d9ea022068e2ee93a68490
Cr-Commit-Position: refs/heads/master@{#413584}
==========

[commit-bot: I haz the power, 2016-08-22 23:43:11]

Patchset 2 (id:??) landed as
https://crrev.com/e19e7089b508c4c6d6d9ea022068e2ee93a68490
Cr-Commit-Position: refs/heads/master@{#413584}

[estevenson, 2016-08-23 02:14:26]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2266363002/ by estevenson@chromium.org.

The reason for reverting is: This CL breaks android perf trybots..

[Nico, 2016-08-30 20:55:29]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-08-30 20:55:29]

Do we really have to unconditionally pipe every single compile through an
additional python process, even if the whitelist feature isn't on? This is
pretty gross.

[estevenson, 2016-08-30 21:05:57]

On 2016/08/30 20:55:29, Nico wrote:
> Do we really have to unconditionally pipe every single compile through an
> additional python process, even if the whitelist feature isn't on? This is
> pretty gross.

You're right, not at all necessary. I'll fix this: http://crbug.com/642498.