headless: Also build the headless shell target on the bot

headless: Also build the headless shell target on the bot

Also make sure the headless shell target builds properly on the headless FYI bot.

BUG=546953
Committed: https://crrev.com/e14cbdf8483f93797dd1605772b3d4cb8e88395e
Cr-Commit-Position: refs/heads/master@{#412204}

[Sami, 2016-08-15 18:00:12]

Description was changed from

==========
headless: Also build the headless shell target on the bot
==========

to

==========
headless: Also build the headless shell target on the bot

Also make sure the headless shell target builds properly on the headless FYI
bot.

BUG=546953
==========

[Sami, 2016-08-15 18:00:12]

skyostil@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-08-15 20:26:56]

LGTM with one comment.

https://codereview.chromium.org/2241363002/diff/1/testing/buildbot/chromium.f...
File testing/buildbot/chromium.fyi.json (right):

https://codereview.chromium.org/2241363002/diff/1/testing/buildbot/chromium.f...
testing/buildbot/chromium.fyi.json:9005: "headless_shell",
In general it would be better for this to be built as a dependency of one of the
test targets that are run on this machine. Is that the long-term plan?

[Sami, 2016-08-16 09:40:59]

https://codereview.chromium.org/2241363002/diff/1/testing/buildbot/chromium.f...
File testing/buildbot/chromium.fyi.json (right):

https://codereview.chromium.org/2241363002/diff/1/testing/buildbot/chromium.f...
testing/buildbot/chromium.fyi.json:9005: "headless_shell",
On 2016/08/15 20:26:56, Ken Russell wrote:
> In general it would be better for this to be built as a dependency of one of
the
> test targets that are run on this machine. Is that the long-term plan?

The problem is that none of the headless unit or browser tests actually need the
headless shell app to run; it's more of an interactive tool for developers. The
app will ultimately go away once we teach Chrome itself to become headless, but
for now it's useful to have around.

[Sami, 2016-08-16 09:41:03]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2016-08-16 09:41:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 10:24:20]

Description was changed from

==========
headless: Also build the headless shell target on the bot

Also make sure the headless shell target builds properly on the headless FYI
bot.

BUG=546953
==========

to

==========
headless: Also build the headless shell target on the bot

Also make sure the headless shell target builds properly on the headless FYI
bot.

BUG=546953
==========

[commit-bot: I haz the power, 2016-08-16 10:24:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-16 10:25:39]

Description was changed from

==========
headless: Also build the headless shell target on the bot

Also make sure the headless shell target builds properly on the headless FYI
bot.

BUG=546953
==========

to

==========
headless: Also build the headless shell target on the bot

Also make sure the headless shell target builds properly on the headless FYI
bot.

BUG=546953

Committed: https://crrev.com/e14cbdf8483f93797dd1605772b3d4cb8e88395e
Cr-Commit-Position: refs/heads/master@{#412204}
==========

[commit-bot: I haz the power, 2016-08-16 10:25:40]

Patchset 1 (id:??) landed as
https://crrev.com/e14cbdf8483f93797dd1605772b3d4cb8e88395e
Cr-Commit-Position: refs/heads/master@{#412204}