Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2241303002: Revert of navigator.share: Resolve promise only after user chooses a target. (Closed)

Created:
4 years, 4 months ago by amineer
Modified:
4 years, 4 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Ted C, gone
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of navigator.share: Resolve promise only after user chooses a target. (patchset #5 id:80001 of https://codereview.chromium.org/2203273002/ ) Reason for revert: Looks to be causing a large number of crashes, see crbug.com/637194. Original issue's description: > navigator.share: Resolve promise only after user chooses a target. > > Previously, would immediately resolve as soon as the share dialog was > shown. This introduces a new issue where the promise *never* resolves > or rejects if the user cancels the share picker (I'm not sure how to do > this or if it's even possible). > > Introduces a bunch of new functionality in the ShareHelper class to > support this new use case. > > BUG=595608 > > Committed: https://crrev.com/610f5e1ea1b1b38926263489d3d235fc834686de > Cr-Commit-Position: refs/heads/master@{#410511} TBR=dtrainor@chromium.org,mgiuca@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=595608 Committed: https://crrev.com/8b746d1fc69b4e2037479b97874ca4cea5ad0842 Cr-Commit-Position: refs/heads/master@{#411975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -121 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java View 14 chunks +38 lines, -103 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java View 3 chunks +30 lines, -15 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
amineer
Created Revert of navigator.share: Resolve promise only after user chooses a target.
4 years, 4 months ago (2016-08-15 16:14:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241303002/1
4 years, 4 months ago (2016-08-15 16:15:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 16:58:06 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 16:59:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b746d1fc69b4e2037479b97874ca4cea5ad0842
Cr-Commit-Position: refs/heads/master@{#411975}

Powered by Google App Engine
This is Rietveld 408576698