Chromium Code Reviews
DescriptionRevert of navigator.share: Resolve promise only after user chooses a target. (patchset #5 id:80001 of https://codereview.chromium.org/2203273002/ )
Reason for revert:
Looks to be causing a large number of crashes, see crbug.com/637194.
Original issue's description:
> navigator.share: Resolve promise only after user chooses a target.
>
> Previously, would immediately resolve as soon as the share dialog was
> shown. This introduces a new issue where the promise *never* resolves
> or rejects if the user cancels the share picker (I'm not sure how to do
> this or if it's even possible).
>
> Introduces a bunch of new functionality in the ShareHelper class to
> support this new use case.
>
> BUG=595608
>
> Committed: https://crrev.com/610f5e1ea1b1b38926263489d3d235fc834686de
> Cr-Commit-Position: refs/heads/master@{#410511}
TBR=dtrainor@chromium.org,mgiuca@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=595608
Committed: https://crrev.com/8b746d1fc69b4e2037479b97874ca4cea5ad0842
Cr-Commit-Position: refs/heads/master@{#411975}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||