Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

Issue 2241273005: Ignore mojo connection errors during shutdown in Geolocation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
diff --git a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
index 0052c3185ccaccd8156342f43f603e053a8907d5..35d63dbf29e3a9acd9a38ae628a4df31c4581ce0 100644
--- a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
+++ b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
@@ -35,6 +35,7 @@
#include "modules/geolocation/GeolocationError.h"
#include "platform/UserGestureIndicator.h"
#include "platform/mojo/MojoHelper.h"
+#include "public/platform/Platform.h"
#include "public/platform/ServiceRegistry.h"
#include "wtf/Assertions.h"
#include "wtf/CurrentTime.h"
@@ -526,6 +527,13 @@ void Geolocation::pageVisibilityChanged()
void Geolocation::onGeolocationConnectionError()
{
+ // If a request is outstanding at process shutdown, this error handler will
+ // be called. In that case, blink has already shut down so do nothing.
+ //
+ // TODO(sammc): Remove this once renderer shutdown is no longer graceful.
+ if (!Platform::current())
+ return;
+
PositionError* error = PositionError::create(PositionError::POSITION_UNAVAILABLE, failedToStartServiceErrorMessage);
error->setIsFatal(true);
handleError(error);
@@ -533,6 +541,13 @@ void Geolocation::onGeolocationConnectionError()
void Geolocation::onPermissionConnectionError()
{
+ // If a request is outstanding at process shutdown, this error handler will
+ // be called. In that case, blink has already shut down so do nothing.
+ //
+ // TODO(sammc): Remove this once renderer shutdown is no longer graceful.
+ if (!Platform::current())
+ return;
+
onGeolocationPermissionUpdated(mojom::blink::PermissionStatus::DENIED);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698