Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2241273003: Attempt to throw away rrect clips of rrects. (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Attempt to throw away rrect clips of rrects. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241273003 Committed: https://skia.googlesource.com/skia/+/7f0d9f39206d0bf67e0a14e9cf3351243c9b5a1b

Patch Set 1 #

Patch Set 2 : Hide behind macro, add comment #

Patch Set 3 : minor #

Patch Set 4 : fix int to scalar warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -7 lines) Patch
M include/core/SkClipStack.h View 2 chunks +20 lines, -2 lines 0 comments Download
M include/core/SkRRect.h View 3 chunks +13 lines, -0 lines 0 comments Download
M include/gpu/GrClip.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkClipStack.cpp View 1 chunk +25 lines, -0 lines 0 comments Download
M src/gpu/GrClipStackClip.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrClipStackClip.cpp View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 2 5 chunks +17 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
bsalomon
Food for thought... this removes the non-aa rrect clips from blurs.skp on skia issue 5635
4 years, 4 months ago (2016-08-15 17:55:24 UTC) #3
robertphillips
On 2016/08/15 17:55:24, bsalomon wrote: > Food for thought... this removes the non-aa rrect clips ...
4 years, 4 months ago (2016-08-15 18:38:47 UTC) #4
bsalomon
On 2016/08/15 18:38:47, robertphillips wrote: > On 2016/08/15 17:55:24, bsalomon wrote: > > Food for ...
4 years, 4 months ago (2016-08-15 18:56:06 UTC) #5
robertphillips
lgtm if you want it.
4 years, 4 months ago (2016-08-15 19:02:21 UTC) #6
bsalomon
On 2016/08/15 19:02:21, robertphillips wrote: > lgtm if you want it. I hid the check ...
4 years, 4 months ago (2016-08-15 19:21:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241273003/40001
4 years, 4 months ago (2016-08-15 20:12:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/10841)
4 years, 4 months ago (2016-08-15 20:32:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241273003/60001
4 years, 4 months ago (2016-08-15 21:13:09 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 21:49:14 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/7f0d9f39206d0bf67e0a14e9cf3351243c9b5a1b

Powered by Google App Engine
This is Rietveld 408576698