Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2241253003: Clear old verified flush IDs when doing OrderingBarrier. (Closed)

Created:
4 years, 4 months ago by jbauman
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Clear old verified flush IDs when doing OrderingBarrier. If a command buffer generates sync tokens but doesn't validate them (letting a different command buffer in the same stream do that), then its queue of unverified flush ids will grow without bound. It can clear them out with little overhead by checking which ones are verified after every GpuChannelHost::OrderingBarrier call. BUG=635051 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2222663002 Cr-Commit-Position: refs/heads/master@{#410840} (cherry picked from commit c5faeccf26cc5e05407c6375231aef4e736138f9) Committed: https://chromium.googlesource.com/chromium/src/+/9987bc7fb26e0807237f31cf33d6b7729714542b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M gpu/ipc/client/command_buffer_proxy_impl.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M gpu/ipc/client/gpu_channel_host.h View 1 chunk +3 lines, -1 line 0 comments Download
M gpu/ipc/client/gpu_channel_host.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
jbauman
4 years, 4 months ago (2016-08-15 21:47:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9987bc7fb26e0807237f31cf33d6b7729714542b.

Powered by Google App Engine
This is Rietveld 408576698