content/common/ssl_status_serialization.cc - Issue 2241213002: Distinguish between SCT invalidity reasons in UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/ssl_status_serialization.cc

Issue 2241213002: Distinguish between SCT invalidity reasons in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changing _MAX to be the last value Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/ssl_status_serialization.cc

diff --git a/content/common/ssl_status_serialization.cc b/content/common/ssl_status_serialization.cc

index a105e7ea450fcd953edec497eeb1a87b32eb00c7..5622c187cd436f99164629e4091c5b9957df7c2f 100644

--- a/content/common/ssl_status_serialization.cc

+++ b/content/common/ssl_status_serialization.cc

@@ -31,9 +31,9 @@ bool CheckSecurityStyle(int security_style) {

bool CheckSCTStatus(uint32_t sct_status) {

switch (sct_status) {

case net::ct::SCT_STATUS_LOG_UNKNOWN:

- case net::ct::SCT_STATUS_INVALID:

+ case net::ct::SCT_STATUS_INVALID_SIGNATURE:

case net::ct::SCT_STATUS_OK:

- case net::ct::SCT_STATUS_MAX:

+ case net::ct::SCT_STATUS_INVALID_TIMESTAMP:

return true;

case net::ct::SCT_STATUS_NONE:

// SCT_STATUS_NONE should never happen, so it isn't valid to