chrome/browser/ui/website_settings/website_settings.cc - Issue 2241213002: Distinguish between SCT invalidity reasons in UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/website_settings.cc

Issue 2241213002: Distinguish between SCT invalidity reasons in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changing _MAX to be the last value Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/website_settings/website_settings.cc

diff --git a/chrome/browser/ui/website_settings/website_settings.cc b/chrome/browser/ui/website_settings/website_settings.cc

index ff46e297c10d2f489e7e5932e3313f37eff8aff9..b634f64148d000faeb4ce4c59bb9c10b359718b5 100644

--- a/chrome/browser/ui/website_settings/website_settings.cc

+++ b/chrome/browser/ui/website_settings/website_settings.cc

@@ -159,8 +159,10 @@ int GetSiteIdentityDetailsMessageByCTInfo(

: IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_CT_VERIFIED);

// Any invalid SCT.

- if (CertificateTransparencyStatusMatchAny(sct_verify_statuses,

- net::ct::SCT_STATUS_INVALID))

+ if (CertificateTransparencyStatusMatchAny(

+ sct_verify_statuses, net::ct::SCT_STATUS_INVALID_TIMESTAMP) ||

+ CertificateTransparencyStatusMatchAny(

+ sct_verify_statuses, net::ct::SCT_STATUS_INVALID_SIGNATURE))

return (is_ev ? IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_EV_CT_INVALID

: IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_CT_INVALID);