Distinguish between SCT invalidity reasons in UMA

content/common/ssl_status_serialization.cc

Index: content/common/ssl_status_serialization.cc
diff --git a/content/common/ssl_status_serialization.cc b/content/common/ssl_status_serialization.cc
index a105e7ea450fcd953edec497eeb1a87b32eb00c7..d4e5c7f7a35cf1ad0472fd8835fbdfd4a11c8d50 100644
--- a/content/common/ssl_status_serialization.cc
+++ b/content/common/ssl_status_serialization.cc
@@ -31,11 +31,12 @@ bool CheckSecurityStyle(int security_style) {
 bool CheckSCTStatus(uint32_t sct_status) {
   switch (sct_status) {
     case net::ct::SCT_STATUS_LOG_UNKNOWN:
-    case net::ct::SCT_STATUS_INVALID:
+    case net::ct::SCT_STATUS_INVALID_SIGNATURE:
     case net::ct::SCT_STATUS_OK:
-    case net::ct::SCT_STATUS_MAX:
+    case net::ct::SCT_STATUS_INVALID_TIMESTAMP:
       return true;
     case net::ct::SCT_STATUS_NONE:
+    case net::ct::SCT_STATUS_MAX:

[Avi (use Gerrit), 2016/08/16 15:25:47]

This is wrong (see my other note). MAX shouldn't be its own value, so it
shouldn't be in this switch at all.

[Eran Messeri, 2016/08/16 16:06:09]

Done, removed.

       // SCT_STATUS_NONE should never happen, so it isn't valid to
       // receive a status of NONE in a serialized SSLStatus.
       return false;