Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6870)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/website_settings/website_settings.cc

Issue 2241213002: Distinguish between SCT invalidity reasons in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc ('k') | chrome/browser/ui/website_settings/website_settings_unittest.cc » ('j') | content/common/ssl_status_serialization.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/website_settings/website_settings.cc
diff --git a/chrome/browser/ui/website_settings/website_settings.cc b/chrome/browser/ui/website_settings/website_settings.cc
index ff46e297c10d2f489e7e5932e3313f37eff8aff9..b634f64148d000faeb4ce4c59bb9c10b359718b5 100644
--- a/chrome/browser/ui/website_settings/website_settings.cc
+++ b/chrome/browser/ui/website_settings/website_settings.cc
@@ -159,8 +159,10 @@ int GetSiteIdentityDetailsMessageByCTInfo(
: IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_CT_VERIFIED);
// Any invalid SCT.
- if (CertificateTransparencyStatusMatchAny(sct_verify_statuses,
- net::ct::SCT_STATUS_INVALID))
+ if (CertificateTransparencyStatusMatchAny(
+ sct_verify_statuses, net::ct::SCT_STATUS_INVALID_TIMESTAMP) ||
+ CertificateTransparencyStatusMatchAny(
+ sct_verify_statuses, net::ct::SCT_STATUS_INVALID_SIGNATURE))
return (is_ev ? IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_EV_CT_INVALID
: IDS_PAGE_INFO_SECURITY_TAB_SECURE_IDENTITY_CT_INVALID);
« no previous file with comments | « chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc ('k') | chrome/browser/ui/website_settings/website_settings_unittest.cc » ('j') | content/common/ssl_status_serialization.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698