Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: content/common/ssl_status_serialization_unittest.cc

Issue 2241213002: Distinguish between SCT invalidity reasons in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changing _MAX to be the last value Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/common/ssl_status_serialization.cc ('k') | net/cert/ct_sct_to_string.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/ssl_status_serialization.h" 5 #include "content/common/ssl_status_serialization.h"
6 6
7 #include "net/ssl/ssl_connection_status_flags.h" 7 #include "net/ssl/ssl_connection_status_flags.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace content { 10 namespace content {
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 } 119 }
120 120
121 // Serialize a status with multiple different |sct_statuses| and test that 121 // Serialize a status with multiple different |sct_statuses| and test that
122 // deserializing works. 122 // deserializing works.
123 TEST(SSLStatusSerializationTest, DeserializeMultipleSCTStatuses) { 123 TEST(SSLStatusSerializationTest, DeserializeMultipleSCTStatuses) {
124 SSLStatus status; 124 SSLStatus status;
125 SetTestStatus(&status); 125 SetTestStatus(&status);
126 status.sct_statuses.push_back(net::ct::SCT_STATUS_LOG_UNKNOWN); 126 status.sct_statuses.push_back(net::ct::SCT_STATUS_LOG_UNKNOWN);
127 status.sct_statuses.push_back(net::ct::SCT_STATUS_LOG_UNKNOWN); 127 status.sct_statuses.push_back(net::ct::SCT_STATUS_LOG_UNKNOWN);
128 status.sct_statuses.push_back(net::ct::SCT_STATUS_OK); 128 status.sct_statuses.push_back(net::ct::SCT_STATUS_OK);
129 status.sct_statuses.push_back(net::ct::SCT_STATUS_INVALID); 129 status.sct_statuses.push_back(net::ct::SCT_STATUS_INVALID_SIGNATURE);
130 status.sct_statuses.push_back(net::ct::SCT_STATUS_INVALID_TIMESTAMP);
130 std::string serialized = SerializeSecurityInfo(status); 131 std::string serialized = SerializeSecurityInfo(status);
131 132
132 SSLStatus deserialized; 133 SSLStatus deserialized;
133 ASSERT_TRUE(DeserializeSecurityInfo(serialized, &deserialized)); 134 ASSERT_TRUE(DeserializeSecurityInfo(serialized, &deserialized));
134 EXPECT_PRED2(SSLStatusAreEqual, status, deserialized); 135 EXPECT_PRED2(SSLStatusAreEqual, status, deserialized);
135 } 136 }
136 137
137 // Serialize a status with a bad SCTVerifyStatus value and test that 138 // Serialize a status with a bad SCTVerifyStatus value and test that
138 // deserializing it fails. 139 // deserializing it fails.
139 TEST(SSLStatusSerializationTest, DeserializeBogusSCTVerifyStatus) { 140 TEST(SSLStatusSerializationTest, DeserializeBogusSCTVerifyStatus) {
140 SSLStatus status; 141 SSLStatus status;
141 SetTestStatus(&status); 142 SetTestStatus(&status);
142 status.sct_statuses.push_back(static_cast<net::ct::SCTVerifyStatus>(100)); 143 status.sct_statuses.push_back(static_cast<net::ct::SCTVerifyStatus>(100));
143 std::string serialized = SerializeSecurityInfo(status); 144 std::string serialized = SerializeSecurityInfo(status);
144 145
145 SSLStatus deserialized; 146 SSLStatus deserialized;
146 ASSERT_FALSE(DeserializeSecurityInfo(serialized, &deserialized)); 147 ASSERT_FALSE(DeserializeSecurityInfo(serialized, &deserialized));
147 EXPECT_PRED2(SSLStatusAreEqual, SSLStatus(), deserialized); 148 EXPECT_PRED2(SSLStatusAreEqual, SSLStatus(), deserialized);
148 } 149 }
149 150
150 } // namespace 151 } // namespace
OLDNEW
« no previous file with comments | « content/common/ssl_status_serialization.cc ('k') | net/cert/ct_sct_to_string.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698