Distinguish between SCT invalidity reasons in UMA

content/common/ssl_status_serialization.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/ssl_status_serialization.h"
 
 #include <stdint.h>
 
 #include "base/logging.h"
 #include "base/numerics/safe_conversions.h"
@@ skipping 13 matching lines @@
       return true;
   }
   return false;
 }
 
 // Checks that an integer |sct_status| is a valid net::ct::SCTVerifyStatus enum
 // value. Returns true if valid, false otherwise.
 bool CheckSCTStatus(uint32_t sct_status) {
   switch (sct_status) {
     case net::ct::SCT_STATUS_LOG_UNKNOWN:
-    case net::ct::SCT_STATUS_INVALID:
+    case net::ct::SCT_STATUS_INVALID_SIGNATURE:
     case net::ct::SCT_STATUS_OK:
-    case net::ct::SCT_STATUS_MAX:
+    case net::ct::SCT_STATUS_INVALID_TIMESTAMP:
       return true;
     case net::ct::SCT_STATUS_NONE:
+    case net::ct::SCT_STATUS_MAX:

[Avi (use Gerrit), 2016/08/16 15:25:47]

This is wrong (see my other note). MAX shouldn't be its own value, so it
shouldn't be in this switch at all.

[Eran Messeri, 2016/08/16 16:06:09]

Done, removed.

       // SCT_STATUS_NONE should never happen, so it isn't valid to
       // receive a status of NONE in a serialized SSLStatus.
       return false;
   }
   return false;
 }
 
 }  // namespace
 
 namespace content {
@@ skipping 70 matching lines @@
   // Sanity check |key_exchange_info|: 0 or greater.
   if (ssl_status->key_exchange_info < 0) {
     *ssl_status = SSLStatus();
     return false;
   }
 
   return true;
 }
 
 }  // namespace content