Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 2241203004: [WASM] Fix build problem on Android (Closed)

Created:
4 years, 4 months ago by Michael Hablich
Modified:
4 years, 4 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[WASM] Fix build problem on Android BUG=v8:5291 R=titzer@chromium.org Committed: https://crrev.com/f1f572b067e6f288edd80cb49fd8094b0bd74f99 Cr-Commit-Position: refs/heads/master@{#38647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/asmjs/asm-wasm-builder.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Hablich
PTAL
4 years, 4 months ago (2016-08-16 09:05:33 UTC) #1
titzer
lgtm
4 years, 4 months ago (2016-08-16 09:10:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241203004/1
4 years, 4 months ago (2016-08-16 09:13:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 09:34:04 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 09:34:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1f572b067e6f288edd80cb49fd8094b0bd74f99
Cr-Commit-Position: refs/heads/master@{#38647}

Powered by Google App Engine
This is Rietveld 408576698