extensions/renderer/script_context_set_unittest.cc - Issue 2241203003: Pass user session type to extension feature checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/script_context_set_unittest.cc

Issue 2241203003: Pass user session type to extension feature checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: split out some stuff Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/script_context_set_unittest.cc

diff --git a/extensions/renderer/script_context_set_unittest.cc b/extensions/renderer/script_context_set_unittest.cc

index 48eae81cbfcc2bf1ac3482e5da23a591b076e521..f7a727d5d8cc3e2765b6bfea5c279fab38ce07ce 100644

--- a/extensions/renderer/script_context_set_unittest.cc

+++ b/extensions/renderer/script_context_set_unittest.cc

@@ -37,7 +37,8 @@ TEST(ScriptContextSetTest, Lifecycle) {

ExtensionIdSet active_extensions;

ScriptContextSet context_set(&active_extensions);

ScriptContext* context = context_set.Register(

- web_frame.frame(), v8_context, 0, 0); // no extension group or world ID

+ web_frame.frame(), v8_context, Feature::SESSION_TYPE_UNSPECIFIED, 0,

+ 0); // no extension group or world ID

// Context is valid and resembles correctness.

EXPECT_TRUE(context->is_valid());