Pass user session type to extension feature checks

extensions/browser/renderer_startup_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/renderer_startup_helper.h"
 
 #include "base/values.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_process_host.h"
 #include "extensions/browser/extension_function_dispatcher.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extensions_browser_client.h"
 #include "extensions/browser/guest_view/web_view/web_view_guest.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/common/extension_set.h"
 #include "extensions/common/extensions_client.h"
 #include "extensions/common/features/feature_channel.h"
+#include "extensions/common/features/feature_session_type.h"
 #include "ui/base/webui/web_ui_util.h"
 
 using content::BrowserContext;
 
 namespace extensions {
 
 RendererStartupHelper::RendererStartupHelper(BrowserContext* browser_context)
     : browser_context_(browser_context) {
   DCHECK(browser_context);
   registrar_.Add(this, content::NOTIFICATION_RENDERER_PROCESS_CREATED,
@@ skipping 29 matching lines @@
 
   bool activity_logging_enabled =
       client->IsActivityLoggingEnabled(process->GetBrowserContext());
   // We only send the ActivityLoggingEnabled message if it is enabled; otherwise
   // the default (not enabled) is correct.
   if (activity_logging_enabled) {
     process->Send(
         new ExtensionMsg_SetActivityLoggingEnabled(activity_logging_enabled));
   }
 
-  // Extensions need to know the channel for API restrictions. Send the channel
-  // to all renderers, as the non-extension renderers may have content scripts.
-  process->Send(new ExtensionMsg_SetChannel(GetCurrentChannel()));
+  // Extensions need to know the channel and the session type for API
+  // restrictions. The values are sent to all renderers, as the non-extension
+  // renderers may have content scripts.
+  process->Send(new ExtensionMsg_SetSessionInfo(
+      GetCurrentChannel(), GetCurrentFeatureSessionType()));

[Devlin, 2016/08/19 00:43:28]

I'm not familiar with where the login flow might happen, but is it possible that
it wouldn't be properly set by the time a renderer is created?

[tbarzic, 2016/08/19 17:23:32]

It's done during profile creation, so it should be done by the time renderers
are created.

 
   // Platform apps need to know the system font.
   // TODO(dbeam): this is not the system font in all cases.
   process->Send(new ExtensionMsg_SetSystemFont(webui::GetFontFamily(),
                                                webui::GetFontSize()));
 
   // Scripting whitelist. This is modified by tests and must be communicated
   // to renderers.
   process->Send(new ExtensionMsg_SetScriptingWhitelist(
       extensions::ExtensionsClient::Get()->GetScriptingWhitelist()));
@@ skipping 119 matching lines @@
     BrowserContext* context) const {
   // Redirected in incognito.
   return ExtensionsBrowserClient::Get()->GetOriginalContext(context);
 }
 
 bool RendererStartupHelperFactory::ServiceIsCreatedWithBrowserContext() const {
   return true;
 }
 
 }  // namespace extensions