Pass user session type to extension feature checks

extensions/renderer/script_context.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_
 #define EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_
 
 #include <memory>
 #include <string>
 #include <utility>
@@ skipping 32 matching lines @@
 // Note that ScriptContexts bound to worker threads will not have the full
 // functionality as those bound to the main RenderThread.
 class ScriptContext : public RequestSender::Source {
  public:
   using RunScriptExceptionHandler = base::Callback<void(const v8::TryCatch&)>;
 
   ScriptContext(const v8::Local<v8::Context>& context,
                 blink::WebLocalFrame* frame,
                 const Extension* extension,
                 Feature::Context context_type,
+                Feature::SessionType session_type,
                 const Extension* effective_extension,
                 Feature::Context effective_context_type);
   ~ScriptContext() override;
 
   // Returns whether |url| from any Extension in |extension_set| is sandboxed,
   // as declared in each Extension's manifest.
   // TODO(kalman): Delete this when crbug.com/466373 is fixed.
   // See comment in HasAccessOrThrowError.
   static bool IsSandboxedPage(const GURL& url);
 
@@ skipping 159 matching lines @@
   // The WebLocalFrame associated with this context. This can be NULL because
   // this object can outlive is destroyed asynchronously.
   blink::WebLocalFrame* web_frame_;
 
   // The extension associated with this context, or NULL if there is none. This
   // might be a hosted app in the case that this context is hosting a web URL.
   scoped_refptr<const Extension> extension_;
 
   // The type of context.
   Feature::Context context_type_;
+  Feature::SessionType session_type_;

[Devlin, 2016/08/17 17:07:35]

This isn't really related to the context - it's global to the process.  I'd
rather we treat this more similarly to channel, rather than trying to curry it
around everywhere.

[tbarzic, 2016/08/17 19:49:01]

yeah, makes sense, I probably should have noticed that before :/

 
   // The effective extension associated with this context, or NULL if there is
   // none. This is different from the above extension if this context is in an
   // about:blank iframe for example.
   scoped_refptr<const Extension> effective_extension_;
 
   // The type of context.
   Feature::Context effective_context_type_;
 
   // Owns and structures the JS that is injected to set up extension bindings.
@@ skipping 16 matching lines @@
   std::unique_ptr<Runner> runner_;
 
   base::ThreadChecker thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(ScriptContext);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_