Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2241183003: Revert of Fix find-in-page re-scope across frame boundaries. (Closed)

Created:
4 years, 4 months ago by Bret
Modified:
4 years, 4 months ago
Reviewers:
paulmeyer, esprehn
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix find-in-page re-scope across frame boundaries. (patchset #4 id:120001 of https://codereview.chromium.org/2186113002/ ) Reason for revert: Multiple bots are timing out on FindRequestManagerTest.RemoveFrame/1 since this patch landed. No one else has touched FindRequestManagerTests recently. Original issue's description: > Fix find-in-page re-scope across frame boundaries. > > There is a bug that can cause a frame to be re-scoped (all matches searched again) when issuing a find next request across a frame boundary, such as from the last match in a frame, which might need to wrap back around to the first match in the same frame. If there are not many matches in that frame, this is not really noticeable except for the ticks in the tickbar sometimes disappearing for a single frame. However, on a page with a huge number of results, this can dramatically slow down the find request and you can clearly see all of the ticks in the tickbar regenerate. > > This patch adjusts the conditions under which a frame is determined to need scoping in WebLocalFrameImpl::requestFind(), in order to not re-scope across frame boundaries but continue to scope in all the cases where it IS needed. > > BUG=618937, 627799 > > Committed: https://crrev.com/b6f12c557fb9b1468ba6f6da5f55cc7cefc045b0 > Cr-Commit-Position: refs/heads/master@{#412025} TBR=esprehn@chromium.org,paulmeyer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=618937, 627799 Committed: https://crrev.com/9f9426efd4f57e650ffc87da7df09766be962875 Cr-Commit-Position: refs/heads/master@{#412068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2090 lines) Patch
M content/browser/find_request_manager_browsertest.cc View 6 chunks +4 lines, -68 lines 0 comments Download
D content/test/data/find_in_long_page.html View 1 chunk +0 lines, -2011 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 2 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Bret
Created Revert of Fix find-in-page re-scope across frame boundaries.
4 years, 4 months ago (2016-08-15 22:13:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241183003/1
4 years, 4 months ago (2016-08-15 22:14:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 22:14:58 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 22:17:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f9426efd4f57e650ffc87da7df09766be962875
Cr-Commit-Position: refs/heads/master@{#412068}

Powered by Google App Engine
This is Rietveld 408576698