Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1417)

Issue 2241183002: CustomElements: each custom descendant should invoke (Closed)

Created:
4 years, 4 months ago by davaajav
Modified:
4 years, 4 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CustomElements: each custom descendant should invoke disconnectedCallback in shadow-including tree order https://dom.spec.whatwg.org/#concept-node-remove BUG=594918 Committed: https://crrev.com/d3b1c03f0593639ebd6c88638c482e8fa178eb39 Cr-Commit-Position: refs/heads/master@{#412157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/custom-elements/spec/remove-element.html View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
davaajav
PTL
4 years, 4 months ago (2016-08-15 07:47:39 UTC) #2
kojii
lgtm
4 years, 4 months ago (2016-08-16 01:30:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241183002/1
4 years, 4 months ago (2016-08-16 01:55:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 03:23:27 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 03:25:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3b1c03f0593639ebd6c88638c482e8fa178eb39
Cr-Commit-Position: refs/heads/master@{#412157}

Powered by Google App Engine
This is Rietveld 408576698