Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2241153002: Clean up CPDF_HintTables. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -129 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_hint_tables.h View 2 chunks +18 lines, -11 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp View 17 chunks +107 lines, -116 lines 1 comment Download

Messages

Total messages: 11 (7 generated)
Lei Zhang
https://codereview.chromium.org/2241153002/diff/1/core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp File core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp (left): https://codereview.chromium.org/2241153002/diff/1/core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp#oldcode178 core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp:178: if (nPages > 0) { Always true. See line ...
4 years, 4 months ago (2016-08-15 05:50:55 UTC) #6
dsinclair
lgtm
4 years, 4 months ago (2016-08-15 13:04:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241153002/1
4 years, 4 months ago (2016-08-15 13:05:00 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 13:05:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/845cac29d76e03960e1de9a019bba67ced84...

Powered by Google App Engine
This is Rietveld 408576698