Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 224113006: Apply OwnPtr|PassOwnPtr to member variables and arguments in ContextFeatures. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 4dbb28f09e84cb73db9682bc3a37649d8a3d3c58..cb895ce3ad62ddc81129329d4b6da8717a101a79 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -347,7 +347,6 @@ WebViewImpl::WebViewImpl(WebViewClient* client)
, m_imeAcceptEvents(true)
, m_operationsAllowed(WebDragOperationNone)
, m_dragOperation(WebDragOperationNone)
- , m_featureSwitchClient(adoptPtr(new ContextFeaturesClientImpl()))
, m_isTransparent(false)
, m_tabsToLinks(false)
, m_layerTreeView(0)
@@ -394,7 +393,7 @@ WebViewImpl::WebViewImpl(WebViewClient* client)
provideNotification(*m_page, notificationPresenterImpl());
provideNavigatorContentUtilsTo(*m_page, NavigatorContentUtilsClientImpl::create(this));
- provideContextFeaturesTo(*m_page, m_featureSwitchClient.get());
+ provideContextFeaturesTo(*m_page, ContextFeaturesClientImpl::create().get());
jochen (gone - plz use gerrit) 2014/04/04 09:07:01 won't this delete the client immediately?
gyuyoung-inactive 2014/04/04 09:51:11 Yes, right. This patch won't delete the client ins
if (RuntimeEnabledFeatures::deviceOrientationEnabled())
DeviceOrientationInspectorAgent::provideTo(*m_page);
provideGeolocationTo(*m_page, m_geolocationClientProxy.get());
« no previous file with comments | « Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698