Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: ash/wm/stacking_controller.cc

Issue 224113005: Eliminate ash::internal namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/stacking_controller.h ('k') | ash/wm/stacking_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/stacking_controller.cc
diff --git a/ash/wm/stacking_controller.cc b/ash/wm/stacking_controller.cc
index 62263d450151082f353a2bcf57c84766a28fe34f..18ecccec6cd57d4177a64748894ca838b7e9b7a9 100644
--- a/ash/wm/stacking_controller.cc
+++ b/ash/wm/stacking_controller.cc
@@ -44,10 +44,8 @@ bool HasTransientParentWindow(const aura::Window* window) {
ui::wm::WINDOW_TYPE_UNKNOWN;
}
-internal::AlwaysOnTopController*
-GetAlwaysOnTopController(aura::Window* root_window) {
- return internal::GetRootWindowController(root_window)->
- always_on_top_controller();
+AlwaysOnTopController* GetAlwaysOnTopController(aura::Window* root_window) {
+ return GetRootWindowController(root_window)->always_on_top_controller();
}
} // namespace
@@ -82,24 +80,22 @@ aura::Window* StackingController::GetDefaultParent(aura::Window* context,
if (IsSystemModal(window))
return GetSystemModalContainer(target_root, window);
else if (HasTransientParentWindow(window))
- return internal::RootWindowController::GetContainerForWindow(
+ return RootWindowController::GetContainerForWindow(
::wm::GetTransientParent(window));
return GetAlwaysOnTopController(target_root)->GetContainer(window);
case ui::wm::WINDOW_TYPE_CONTROL:
- return GetContainerById(
- target_root, internal::kShellWindowId_UnparentedControlContainer);
+ return GetContainerById(target_root,
+ kShellWindowId_UnparentedControlContainer);
case ui::wm::WINDOW_TYPE_PANEL:
if (wm::GetWindowState(window)->panel_attached())
- return GetContainerById(target_root,
- internal::kShellWindowId_PanelContainer);
+ return GetContainerById(target_root, kShellWindowId_PanelContainer);
else
return GetAlwaysOnTopController(target_root)->GetContainer(window);
case ui::wm::WINDOW_TYPE_MENU:
- return GetContainerById(
- target_root, internal::kShellWindowId_MenuContainer);
+ return GetContainerById(target_root, kShellWindowId_MenuContainer);
case ui::wm::WINDOW_TYPE_TOOLTIP:
- return GetContainerById(
- target_root, internal::kShellWindowId_DragImageAndTooltipContainer);
+ return GetContainerById(target_root,
+ kShellWindowId_DragImageAndTooltipContainer);
default:
NOTREACHED() << "Window " << window->id()
<< " has unhandled type " << window->type();
@@ -124,8 +120,7 @@ aura::Window* StackingController::GetSystemModalContainer(
Shell::GetInstance()->session_state_delegate();
if (!session_state_delegate->IsUserSessionBlocked() ||
!::wm::GetTransientParent(window)) {
- return GetContainerById(root,
- internal::kShellWindowId_SystemModalContainer);
+ return GetContainerById(root, kShellWindowId_SystemModalContainer);
}
// Otherwise those that originate from LockScreen container and above are
@@ -133,12 +128,10 @@ aura::Window* StackingController::GetSystemModalContainer(
int window_container_id =
::wm::GetTransientParent(window)->parent()->id();
aura::Window* container = NULL;
- if (window_container_id < internal::kShellWindowId_LockScreenContainer) {
- container = GetContainerById(
- root, internal::kShellWindowId_SystemModalContainer);
+ if (window_container_id < kShellWindowId_LockScreenContainer) {
+ container = GetContainerById(root, kShellWindowId_SystemModalContainer);
} else {
- container = GetContainerById(
- root, internal::kShellWindowId_LockSystemModalContainer);
+ container = GetContainerById(root, kShellWindowId_LockSystemModalContainer);
}
return container;
« no previous file with comments | « ash/wm/stacking_controller.h ('k') | ash/wm/stacking_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698