Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: ash/wm/panels/panel_layout_manager_unittest.cc

Issue 224113005: Eliminate ash::internal namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/panels/panel_layout_manager.cc ('k') | ash/wm/panels/panel_window_event_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/panels/panel_layout_manager_unittest.cc
diff --git a/ash/wm/panels/panel_layout_manager_unittest.cc b/ash/wm/panels/panel_layout_manager_unittest.cc
index faba4f778625327d71f8f1f71b85cef7be8efc8d..853f64868143ba3dd85113557b5086e598dda691 100644
--- a/ash/wm/panels/panel_layout_manager_unittest.cc
+++ b/ash/wm/panels/panel_layout_manager_unittest.cc
@@ -38,7 +38,6 @@
#include "ui/views/widget/widget.h"
namespace ash {
-namespace internal {
using aura::test::WindowIsAbove;
@@ -75,7 +74,7 @@ class PanelLayoutManagerTest : public test::AshTestBase {
aura::Window* GetPanelContainer(aura::Window* panel) {
return Shell::GetContainer(panel->GetRootWindow(),
- internal::kShellWindowId_PanelContainer);
+ kShellWindowId_PanelContainer);
}
views::Widget* GetCalloutWidgetForPanel(aura::Window* panel) {
@@ -238,9 +237,9 @@ class PanelLayoutManagerTest : public test::AshTestBase {
void SetShelfAutoHideBehavior(aura::Window* window,
ShelfAutoHideBehavior behavior) {
- internal::ShelfLayoutManager* shelf =
- RootWindowController::ForWindow(window)->shelf()->
- shelf_layout_manager();
+ ShelfLayoutManager* shelf = RootWindowController::ForWindow(window)
+ ->shelf()
+ ->shelf_layout_manager();
shelf->SetAutoHideBehavior(behavior);
ShelfView* shelf_view = GetShelfView(Shelf::ForWindow(window));
test::ShelfViewTestAPI test_api(shelf_view);
@@ -249,13 +248,13 @@ class PanelLayoutManagerTest : public test::AshTestBase {
void SetShelfVisibilityState(aura::Window* window,
ShelfVisibilityState visibility_state) {
- internal::ShelfLayoutManager* shelf =
- RootWindowController::ForWindow(window)->shelf()->
- shelf_layout_manager();
+ ShelfLayoutManager* shelf = RootWindowController::ForWindow(window)
+ ->shelf()
+ ->shelf_layout_manager();
shelf->SetState(visibility_state);
}
- internal::ShelfView* GetShelfView(Shelf* shelf) {
+ ShelfView* GetShelfView(Shelf* shelf) {
return test::ShelfTestAPI(shelf).shelf_view();
}
@@ -609,10 +608,10 @@ TEST_F(PanelLayoutManagerTest, PanelMoveBetweenMultipleDisplays) {
EXPECT_EQ(root_windows[1], p1_d2->GetRootWindow());
EXPECT_EQ(root_windows[1], p2_d2->GetRootWindow());
- EXPECT_EQ(internal::kShellWindowId_PanelContainer, p1_d1->parent()->id());
- EXPECT_EQ(internal::kShellWindowId_PanelContainer, p2_d1->parent()->id());
- EXPECT_EQ(internal::kShellWindowId_PanelContainer, p1_d2->parent()->id());
- EXPECT_EQ(internal::kShellWindowId_PanelContainer, p2_d2->parent()->id());
+ EXPECT_EQ(kShellWindowId_PanelContainer, p1_d1->parent()->id());
+ EXPECT_EQ(kShellWindowId_PanelContainer, p2_d1->parent()->id());
+ EXPECT_EQ(kShellWindowId_PanelContainer, p1_d2->parent()->id());
+ EXPECT_EQ(kShellWindowId_PanelContainer, p2_d2->parent()->id());
// Test a panel on 1st display.
// Clicking on the same display has no effect.
@@ -788,5 +787,4 @@ TEST_F(PanelLayoutManagerTest, PanelsHideAndRestoreWithShelf) {
INSTANTIATE_TEST_CASE_P(LtrRtl, PanelLayoutManagerTextDirectionTest,
testing::Bool());
-} // namespace internal
} // namespace ash
« no previous file with comments | « ash/wm/panels/panel_layout_manager.cc ('k') | ash/wm/panels/panel_window_event_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698