Source/core/editing/VisibleSelection.h - Issue 224113002: Oilpan: move Range object to the oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisibleSelection.h

Issue 224113002: Oilpan: move Range object to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use STACK_ALLOCATED() + incorporate ager's overview of macros in this area. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/VisibleSelection.h

diff --git a/Source/core/editing/VisibleSelection.h b/Source/core/editing/VisibleSelection.h

index 2b7bd2a7bbba191042de33dffc24985808dec59a..c14630c15d700258279bc14bf5c7d10716c4e681 100644

--- a/Source/core/editing/VisibleSelection.h

+++ b/Source/core/editing/VisibleSelection.h

@@ -93,12 +93,12 @@ public:

bool expandUsingGranularity(TextGranularity granularity);

// We don't yet support multi-range selections, so we only ever have one range to return.

- PassRefPtr<Range> firstRange() const;

+ PassRefPtrWillBeRawPtr<Range> firstRange() const;

// FIXME: Most callers probably don't want this function, but are using it

// for historical reasons. toNormalizedRange contracts the range around

// text, and moves the caret upstream before returning the range.

- PassRefPtr<Range> toNormalizedRange() const;

+ PassRefPtrWillBeRawPtr<Range> toNormalizedRange() const;

Element* rootEditableElement() const;

bool isContentEditable() const;