Source/core/editing/SurroundingText.h - Issue 224113002: Oilpan: move Range object to the oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/SurroundingText.h

Issue 224113002: Oilpan: move Range object to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use STACK_ALLOCATED() + incorporate ager's overview of macros in this area. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/SurroundingText.h

diff --git a/Source/core/editing/SurroundingText.h b/Source/core/editing/SurroundingText.h

index 03ef289415541b71ea9eee35ca811cc852bc07e6..571a2d5aa189cc9ed7983dd85f0b6b5b446847d5 100644

--- a/Source/core/editing/SurroundingText.h

+++ b/Source/core/editing/SurroundingText.h

@@ -31,6 +31,7 @@

#ifndef SurroundingText_h

#define SurroundingText_h

+#include "platform/heap/Handle.h"

#include "wtf/text/WTFString.h"

namespace WebCore {

@@ -46,10 +47,10 @@ public:

String content() const;

unsigned positionOffsetInContent() const;

- PassRefPtr<Range> rangeFromContentOffsets(unsigned startOffsetInContent, unsigned endOffsetInContent);

+ PassRefPtrWillBeRawPtr<Range> rangeFromContentOffsets(unsigned startOffsetInContent, unsigned endOffsetInContent);

private:

- RefPtr<Range> m_contentRange;

+ RefPtrWillBePersistent<Range> m_contentRange;

size_t m_positionOffsetInContent;

};