Source/core/editing/InsertListCommand.cpp - Issue 224113002: Oilpan: move Range object to the oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/InsertListCommand.cpp

Issue 224113002: Oilpan: move Range object to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use STACK_ALLOCATED() + incorporate ager's overview of macros in this area. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/InsertListCommand.cpp

diff --git a/Source/core/editing/InsertListCommand.cpp b/Source/core/editing/InsertListCommand.cpp

index 6de0c13ab2d15d5181f054b843e3213b97ec8f87..ea1a0aa087e743b9b3d19f525211ed473a6198ac 100644

--- a/Source/core/editing/InsertListCommand.cpp

+++ b/Source/core/editing/InsertListCommand.cpp

@@ -139,7 +139,7 @@ void InsertListCommand::doApply()

int indexForEndOfSelection = indexForVisiblePosition(endOfSelection, scope);

bool forceCreateList = !selectionHasListOfType(selection, listTag);

- RefPtr<Range> currentSelection = endingSelection().firstRange();

+ RefPtrWillBeRawPtr<Range> currentSelection = endingSelection().firstRange();

VisiblePosition startOfCurrentParagraph = startOfSelection;

while (!inSameParagraph(startOfCurrentParagraph, startOfLastParagraph, CanCrossEditingBoundary)) {

// doApply() may operate on and remove the last paragraph of the selection from the document