Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 224113002: Oilpan: move Range object to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use STACK_ALLOCATED() + incorporate ager's overview of macros in this area. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/Document.h » ('j') | Source/core/editing/Editor.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/accessibility/AXRenderObject.cpp
diff --git a/Source/core/accessibility/AXRenderObject.cpp b/Source/core/accessibility/AXRenderObject.cpp
index be09e6ae0217b9b7aeb4adc814e2e29892c9c314..a1e61f98bc59314ffd2c64ff5215ab7bfbdcd871 100644
--- a/Source/core/accessibility/AXRenderObject.cpp
+++ b/Source/core/accessibility/AXRenderObject.cpp
@@ -1742,7 +1742,7 @@ VisiblePosition AXRenderObject::visiblePositionForIndex(int index) const
if (index <= 0)
return VisiblePosition(firstPositionInOrBeforeNode(node), DOWNSTREAM);
- RefPtr<Range> range = Range::create(m_renderer->document());
+ RefPtrWillBeRawPtr<Range> range = Range::create(m_renderer->document());
range->selectNodeContents(node, IGNORE_EXCEPTION);
CharacterIterator it(range.get());
it.advance(index - 1);
@@ -1768,7 +1768,7 @@ int AXRenderObject::indexForVisiblePosition(const VisiblePosition& pos) const
if (indexPosition.isNull() || highestEditableRoot(indexPosition, HasEditableAXRole) != node)
return 0;
- RefPtr<Range> range = Range::create(m_renderer->document());
+ RefPtrWillBeRawPtr<Range> range = Range::create(m_renderer->document());
range->setStart(node, 0, IGNORE_EXCEPTION);
range->setEnd(indexPosition, IGNORE_EXCEPTION);
@@ -1863,7 +1863,7 @@ AXObject::PlainTextRange AXRenderObject::ariaSelectedTextRange() const
return PlainTextRange();
VisibleSelection visibleSelection = selection();
- RefPtr<Range> currentSelectionRange = visibleSelection.toNormalizedRange();
+ RefPtrWillBeRawPtr<Range> currentSelectionRange = visibleSelection.toNormalizedRange();
if (!currentSelectionRange || !currentSelectionRange->intersectsNode(node, IGNORE_EXCEPTION))
return PlainTextRange();
« no previous file with comments | « no previous file | Source/core/dom/Document.h » ('j') | Source/core/editing/Editor.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698