Issue 22411004: Re-organize Android scripts

Issue 22411004: Re-organize Android scripts (Closed)

Created:
7 years, 4 months ago by borenet

Modified:
7 years, 4 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Re-organize Android scripts Addresses https://code.google.com/p/skia/issues/detail?id=1486 R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=10585

Patch Set 3 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -97 lines)			Patch
M	platform_tools/android/bin/android_gdb	View	1	2 chunks	+5 lines, -26 lines	0 comments	Download
M	platform_tools/android/bin/android_gdb_exe	View	1 2	3 chunks	+3 lines, -24 lines	0 comments	Download
M	platform_tools/android/bin/android_gdbserver	View		2 chunks	+5 lines, -11 lines	0 comments	Download
M	platform_tools/android/bin/android_make	View		2 chunks	+6 lines, -26 lines	0 comments	Download
M	platform_tools/android/bin/android_setup.sh	View	1 2	5 chunks	+49 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

djsollen

lgtm lgtm with one nit https://codereview.chromium.org/22411004/diff/2001/platform_tools/android/bin/android_setup.sh File platform_tools/android/bin/android_setup.sh (right): https://codereview.chromium.org/22411004/diff/2001/platform_tools/android/bin/android_setup.sh#newcode6 platform_tools/android/bin/android_setup.sh:6: deviceID="" should we make ...

7 years, 4 months ago (2013-08-06 19:56:29 UTC) #2

borenet

Patch set 3. https://codereview.chromium.org/22411004/diff/2001/platform_tools/android/bin/android_setup.sh File platform_tools/android/bin/android_setup.sh (right): https://codereview.chromium.org/22411004/diff/2001/platform_tools/android/bin/android_setup.sh#newcode6 platform_tools/android/bin/android_setup.sh:6: deviceID="" On 2013/08/06 19:56:29, djsollen wrote: ...

7 years, 4 months ago (2013-08-06 20:07:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/22411004/8001

7 years, 4 months ago (2013-08-06 20:17:35 UTC) #5

borenet

7 years, 4 months ago (2013-08-06 20:32:32 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r10585 (presubmit successful).

Expand Messages | Collapse Messages