Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 22411003: Move i18n extension's date-format C++ code to runtime (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Move i18n extension's date-format C++ code to runtime BUG=v8:2745 R=dcarney@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16086

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -439 lines) Patch
D src/extensions/i18n/date-format.h View 1 chunk +0 lines, -71 lines 0 comments Download
D src/extensions/i18n/date-format.cc View 1 chunk +0 lines, -329 lines 0 comments Download
M src/extensions/i18n/date-format.js View 5 chunks +3 lines, -7 lines 0 comments Download
M src/extensions/i18n/i18n-extension.cc View 2 chunks +0 lines, -10 lines 0 comments Download
A + src/i18n.h View 2 chunks +28 lines, -20 lines 0 comments Download
A src/i18n.cc View 1 1 chunk +297 lines, -0 lines 0 comments Download
M src/runtime.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 2 chunks +112 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Dan & Michael, can you please review this? The default tests and intl tests all ...
7 years, 4 months ago (2013-08-06 12:17:02 UTC) #1
Michael Starzinger
LGTM.
7 years, 4 months ago (2013-08-06 16:20:31 UTC) #2
dcarney
lgtm
7 years, 4 months ago (2013-08-06 16:31:26 UTC) #3
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-07 03:41:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r16086 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698