Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2241083002: Revert of Always use an external begin frame source in the renderer (Closed)

Created:
4 years, 4 months ago by caseq
Modified:
4 years, 4 months ago
Reviewers:
no sievers, enne (OOO)
CC:
chromium-reviews, danakj, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Always use an external begin frame source in the renderer (patchset #4 id:60001 of https://codereview.chromium.org/2083423006/ ) Reason for revert: This apparently broke blimp tests: https://build.chromium.org/p/chromium.linux/builders/Blimp%20Linux%20%28dbg%29/builds/6898/steps/blimp_browsertests/logs/stdio Original issue's description: > Always use an external begin frame source in the renderer > > Tests still aren't using an external begin frame source, so this is just > a staging step. The next step is to move BFS into output surface, > remove external begin frame sources from cc's API, and then to remove > the default BFS in cc's proxies once output sources are the only way to > get a BFS. > > Committed: https://crrev.com/3ba9b9d3500d799ee36bd41d0b36aecbc924111a > Cr-Commit-Position: refs/heads/master@{#411809} TBR=sievers@chromium.org,enne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/ba7296e9230d751eeddd23b42be7f6f7cf487a60 Cr-Commit-Position: refs/heads/master@{#411839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M content/renderer/gpu/render_widget_compositor.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
caseq
Created Revert of Always use an external begin frame source in the renderer
4 years, 4 months ago (2016-08-13 00:58:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241083002/1
4 years, 4 months ago (2016-08-13 00:58:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-13 00:59:36 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-13 01:06:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba7296e9230d751eeddd23b42be7f6f7cf487a60
Cr-Commit-Position: refs/heads/master@{#411839}

Powered by Google App Engine
This is Rietveld 408576698