Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1642)

Unified Diff: content/renderer/media/webmediaplayer_impl.h

Issue 224093011: Move DataSourceHost to BufferedDataSourceHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Split time computation into BufferedDataSourceHostImpl. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webmediaplayer_impl.h
diff --git a/content/renderer/media/webmediaplayer_impl.h b/content/renderer/media/webmediaplayer_impl.h
index d59b7c2a390fe0a6d82ec322f3886447643abe0b..a2c0c1898ac443c83560b0a9f6a98884948e0931 100644
--- a/content/renderer/media/webmediaplayer_impl.h
+++ b/content/renderer/media/webmediaplayer_impl.h
@@ -13,6 +13,8 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/threading/thread.h"
+#include "content/common/content_export.h"
+#include "content/renderer/media/buffered_data_source.h"
#include "content/renderer/media/crypto/proxy_decryptor.h"
#include "content/renderer/media/video_frame_compositor.h"
#include "media/base/audio_renderer_sink.h"
@@ -63,7 +65,7 @@ class WebTextTrackImpl;
// The canonical implementation of blink::WebMediaPlayer that's backed by
// media::Pipeline. Handles normal resource loading, Media Source, and
// Encrypted Media.
-class WebMediaPlayerImpl
+class CONTENT_EXPORT WebMediaPlayerImpl
: public blink::WebMediaPlayer,
public base::SupportsWeakPtr<WebMediaPlayerImpl> {
public:
@@ -114,6 +116,8 @@ class WebMediaPlayerImpl
virtual blink::WebMediaPlayer::NetworkState networkState() const;
virtual blink::WebMediaPlayer::ReadyState readyState() const;
+ // TODO(sandersd): Change this to non-const in blink::WebMediaPlayer.
+ // http://crbug.com/360251
virtual bool didLoadingProgress() const;
virtual bool hasSingleSecurityOrigin() const;
@@ -244,9 +248,6 @@ class WebMediaPlayerImpl
blink::WebMediaPlayer::NetworkState network_state_;
blink::WebMediaPlayer::ReadyState ready_state_;
- // Keep a list of buffered time ranges.
- blink::WebTimeRanges buffered_;
-
// Message loops for posting tasks on Chrome's main thread. Also used
// for DCHECKs so methods calls won't execute in the wrong thread.
const scoped_refptr<base::MessageLoopProxy> main_loop_;
@@ -320,6 +321,8 @@ class WebMediaPlayerImpl
scoped_ptr<media::Demuxer> demuxer_;
media::ChunkDemuxer* chunk_demuxer_;
+ BufferedDataSourceHostImpl buffered_;
+
// Temporary for EME v0.1. In the future the init data type should be passed
// through GenerateKeyRequest() directly from WebKit.
std::string init_data_type_;

Powered by Google App Engine
This is Rietveld 408576698