Update chromium.android.json

build/android/test_wrapper/logdog_wrapper.py

 #!/usr/bin/env python
 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Wrapper for adding logdog streaming support to swarming tasks."""
 
 import argparse
 import logging
 import os
@@ skipping 39 matching lines @@
     args.prefix = args.prefix.replace('${SWARMING_TASK_ID}',
                                       os.environ.get('SWARMING_TASK_ID'))
   url = CreateUrl('luci-logdog.appspot.com', args.project, args.prefix,
                   args.name)
   logdog_cmd = [args.logdog_bin_cmd, '-project', args.project,
                 '-output', 'logdog,host=%s' % args.logdog_server,
                 '-prefix', args.prefix,
                 '-service-account-json', args.service_account_json,
                 'stream', '-source', args.source,
                 '-stream', '-name=%s' % args.name]
-  subprocess.call(logdog_cmd)
-  logging.info('Logcats are located at: %s', url)
+  if os.path.exists(args.logdog_bin_cmd):

[dnj, 2016/08/12 19:29:02]

Does this mean that if binary doesn't exist, nothing will be uploaded? Shouldn't
that be an error?

[dnj, 2016/08/12 19:34:57]

I guess what I'm saying is:
1) We're explicitly making a point of loading this binary.
2) We hedge against that loading not actually happening.

It seems that (2) contradicts the expected success of (1). If we make a point of
having the binary on the system, we should expect that it will be there, and
fail if it's not.

[dnj, 2016/08/12 19:49:01]

Maybe the thing to do here is surround the engire "logdog_cmd = ..." block in an
"if args.logdog_bin_cmd".

This means:
1) Don't check for binary existence. If someone specifies a binary and it's
invalid, that's an error.
2) Don't do any LogDog work when someone doesn't specify the flag.

WDYT?

+    subprocess.call(logdog_cmd)
+    logging.info('Logcats are located at: %s', url)
   return result
 
 
 if __name__ == '__main__':
   sys.exit(main())