chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h - Issue 2240883002: Make ClearBrowsingDataHandler only observe its own removal task

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

Issue 2240883002: Make ClearBrowsingDataHandler only observe its own removal task (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js ('k') | chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc » ('j') | chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

diff --git a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

index 02f0202afc9eb7be30d54fe20c28865b00bdc6bd..d91bb719a763e4cfaacadb209240dfc8435d771e 100644

--- a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

+++ b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h

@@ -46,7 +46,7 @@ class ClearBrowsingDataHandler : public SettingsPageUIHandler,

void HandleClearBrowsingData(const base::ListValue* value);

// BrowsingDataRemover::Observer implementation.

- void OnBrowsingDataRemoving(bool is_removing) override;

+ void OnBrowsingDataRemoverDone() override;

// Updates UI when the pref to allow clearing history changes.

virtual void OnBrowsingHistoryPrefChanged();

@@ -89,8 +89,7 @@ class ClearBrowsingDataHandler : public SettingsPageUIHandler,

ScopedObserver<ProfileSyncService, sync_driver::SyncServiceObserver>

sync_service_observer_;

- // Observe the remover progress.

- BrowsingDataRemover* remover_;

+ // Ensures that we unregister ourselves as BrowsingDataRemover::Observer.

ScopedObserver<BrowsingDataRemover, BrowsingDataRemover::Observer>

remover_observer_;