chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js - Issue 2240883002: Make ClearBrowsingDataHandler only observe its own removal task

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js

Issue 2240883002: Make ClearBrowsingDataHandler only observe its own removal task (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover.cc ('k') | chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js » ('j') | chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js

diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js

index bcfb36966f34be645cee0eff9de0d1b7287b181f..795f204e6c961d3cac2023e420e59f69804e7c55 100644

--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js

+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js

@@ -20,8 +20,8 @@ cr.define('settings', function() {

/**

* Kick off counter updates and return initial state.

* @return {!Promise<boolean>} Signal when the setup is complete. Boolean

- * passed to Promise is whether any data is currently being cleared for

- * this profile.

+ * passed to Promise is whether a deletion task from this dialog is

+ * currently running (e.g. when a dialog was closed and reopened).

initialize: function() {},

};