chrome/browser/browsing_data/browsing_data_remover.cc - Issue 2240883002: Make ClearBrowsingDataHandler only observe its own removal task

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.cc

Issue 2240883002: Make ClearBrowsingDataHandler only observe its own removal task (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Only forward-declare in the header file Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover.h ('k') | chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js » ('j') | chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_remover.cc

diff --git a/chrome/browser/browsing_data/browsing_data_remover.cc b/chrome/browser/browsing_data/browsing_data_remover.cc

index cf4f0af778df91208481c01ea16ddb2edd4b9b25..6c97bc33c3124f8087bc2401439ac0f33e153562 100644

--- a/chrome/browser/browsing_data/browsing_data_remover.cc

+++ b/chrome/browser/browsing_data/browsing_data_remover.cc

@@ -331,8 +331,6 @@ void BrowsingDataRemover::Shutdown() {

void BrowsingDataRemover::SetRemoving(bool is_removing) {

DCHECK_NE(is_removing_, is_removing);

is_removing_ = is_removing;

- FOR_EACH_OBSERVER(Observer, observer_list_,

- OnBrowsingDataRemoving(is_removing));

}

void BrowsingDataRemover::Remove(const TimeRange& time_range,