Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2240873003: Fix a bug that prevents all reuse of ResourcePool resources. (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 4 months ago
Reviewers:
ccameron
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug that prevents all reuse of ResourcePool resources. The ColorSpace parameter was being lost when creating a ResourcePool resource. BUG=44872 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/53d7727467e44f51ad9fe10e0f0d2a2ef2366a10 Cr-Commit-Position: refs/heads/master@{#411812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M cc/resources/resource.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/resources/scoped_resource.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
erikchen
ccameron: Please review. Lucky break here - I was writing tests that started failing when ...
4 years, 4 months ago (2016-08-12 22:10:43 UTC) #4
ccameron
Lgtm
4 years, 4 months ago (2016-08-12 22:38:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240873003/1
4 years, 4 months ago (2016-08-12 23:11:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 23:15:54 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 23:17:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53d7727467e44f51ad9fe10e0f0d2a2ef2366a10
Cr-Commit-Position: refs/heads/master@{#411812}

Powered by Google App Engine
This is Rietveld 408576698