Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2240873002: Settings Router Refactor: Fix typo in fonts subpage route. (Closed)

Created:
4 years, 4 months ago by tommycli
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings Router Refactor: Fix typo in fonts subpage route. BUG=632382 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a114fa87c2ee8e854f12b371a29d8a0e7da39788 Cr-Commit-Position: refs/heads/master@{#411695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
tommycli
dbeam: PTAL, thanks
4 years, 4 months ago (2016-08-12 16:50:06 UTC) #4
Dan Beam
lgtm
4 years, 4 months ago (2016-08-12 17:38:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240873002/1
4 years, 4 months ago (2016-08-12 17:39:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 17:43:59 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 17:47:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a114fa87c2ee8e854f12b371a29d8a0e7da39788
Cr-Commit-Position: refs/heads/master@{#411695}

Powered by Google App Engine
This is Rietveld 408576698