Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2240853003: Revert of [Chromedriver] Disable testColdExecuteScript Py test on HEAD (Closed)

Created:
4 years, 4 months ago by samuong
Modified:
4 years, 4 months ago
Reviewers:
gmanikpure
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromedriver] Disable testColdExecuteScript Py test on HEAD (patchset #1 id:1 of https://codereview.chromium.org/2223143002/ ) Reason for revert: This test was broken because the ChromeDriver reference builds were out-of-date. I've updated them now, so I'm reverting this CL to re-enable the test. See the bug for more context. Original issue's description: > [Chromedriver] Disable testColdExecuteScript Py test on HEAD > > BUG=chromedriver:1450 > > Committed: https://crrev.com/ff162e64d53e5c9d9833b5b376ef6bc63e68a8d3 > Cr-Commit-Position: refs/heads/master@{#410411} TBR=gmanikpure@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromedriver:1450 Committed: https://crrev.com/98f8cde83862abbef6e8788bfae35c1ec5076362 Cr-Commit-Position: refs/heads/master@{#411683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
samuong
Created Revert of [Chromedriver] Disable testColdExecuteScript Py test on HEAD
4 years, 4 months ago (2016-08-12 16:15:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240853003/1
4 years, 4 months ago (2016-08-12 16:15:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 17:16:14 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 17:19:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98f8cde83862abbef6e8788bfae35c1ec5076362
Cr-Commit-Position: refs/heads/master@{#411683}

Powered by Google App Engine
This is Rietveld 408576698