Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: build/android/pylib/local/device/local_device_environment.py

Issue 2240853002: Revert of Logdog for logcats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/BUILD.gn ('k') | build/android/test_wrapper/logdog_wrapper.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/local/device/local_device_environment.py
diff --git a/build/android/pylib/local/device/local_device_environment.py b/build/android/pylib/local/device/local_device_environment.py
index 9faf0f7111f9a953919947e705b4f36b04f4d440..431614377efa68bd4cffecc6158f13d0d6673965 100644
--- a/build/android/pylib/local/device/local_device_environment.py
+++ b/build/android/pylib/local/device/local_device_environment.py
@@ -188,17 +188,8 @@
try:
m.Stop()
m.Close()
- _, temp_path = tempfile.mkstemp()
- with open(m.output_file, 'r') as infile:
- with open(temp_path, 'w') as outfile:
- for line in infile:
- outfile.write('Device(%s) %s' % (m.adb.GetDeviceSerial(), line))
- shutil.move(temp_path, m.output_file)
except base_error.BaseError:
logging.exception('Failed to stop logcat monitor for %s',
- m.adb.GetDeviceSerial())
- except IOError:
- logging.exception('Failed to locate logcat for device %s',
m.adb.GetDeviceSerial())
if self._logcat_output_file:
« no previous file with comments | « build/android/BUILD.gn ('k') | build/android/test_wrapper/logdog_wrapper.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698