Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2240833002: Metric for opening the Download Manager UI from the NTP More-card (Closed)

Created:
4 years, 4 months ago by Philipp Keck
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer, jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org, ntp-dev+reviews_chromium.org, Marc Treib
Base URL:
https://chromium.googlesource.com/chromium/src.git@offlinesplit
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Metric for opening the Download Manager UI from the NTP More-card Add a MobileNTPSwitchToDownloadManager metric to track the usage of the More-card of the Downloads section on the NTP. BUG=None Committed: https://crrev.com/60675b983ddcbb0f45d6b77598b26dc26c0023e9 Cr-Commit-Position: refs/heads/master@{#411698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Philipp Keck
PTAL, thank you!
4 years, 4 months ago (2016-08-12 13:46:08 UTC) #2
Bernhard Bauer
lgtm
4 years, 4 months ago (2016-08-12 13:50:03 UTC) #3
jwd
lgtm
4 years, 4 months ago (2016-08-12 14:56:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240833002/1
4 years, 4 months ago (2016-08-12 17:09:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 17:49:30 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 17:52:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60675b983ddcbb0f45d6b77598b26dc26c0023e9
Cr-Commit-Position: refs/heads/master@{#411698}

Powered by Google App Engine
This is Rietveld 408576698