Issue 2240823002: Deserialize ResolvedAsts and ResolutionImpacts only when needed for compilation.

Issue 2240823002: Deserialize ResolvedAsts and ResolutionImpacts only when needed for compilation. (Closed)

Created:
4 years, 4 months ago by Johnni Winther

Modified:
4 years, 4 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Deserialize ResolvedAsts and ResolutionImpacts only when needed for compilation. The only real change needed for this was to use [ConstantConstructor] for deserialized constant constructors (instead of their ASTs) R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/f1d61727e39aad26d9f5c6c60c0008631673ef07

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+174 lines, -92 lines)			Patch
M	pkg/compiler/lib/src/compile_time_constants.dart	View	8 chunks	+58 lines, -23 lines	0 comments	Download
M	pkg/compiler/lib/src/serialization/system.dart	View	3 chunks	+88 lines, -57 lines	0 comments	Download
M	pkg/compiler/lib/src/serialization/task.dart	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/universe/call_structure.dart	View	2 chunks	+12 lines, -7 lines	0 comments	Download
M	tests/compiler/dart2js/serialization/helper.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/serialization/reserialization_test.dart	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

Johnni Winther

4 years, 4 months ago (2016-08-16 07:54:53 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f1d61727e39aad26d9f5c6c60c0008631673ef07 (presubmit successful).