Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2240803002: Clean up some PDF code. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up some PDF code. - Unused variables in pdf/out_of_process_instance.cc - Weird line breaks in chrome/browser/resources/pdf/pdf.js CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/6a8a3ecc64d3d1b31071ed83100639458f3fab52 Cr-Commit-Position: refs/heads/master@{#411847}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 6 chunks +7 lines, -12 lines 0 comments Download
M pdf/out_of_process_instance.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Lei Zhang
4 years, 4 months ago (2016-08-12 07:39:41 UTC) #5
Dan Beam
lgtm
4 years, 4 months ago (2016-08-12 21:29:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240803002/1
4 years, 4 months ago (2016-08-13 01:33:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-13 01:37:31 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-13 01:41:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a8a3ecc64d3d1b31071ed83100639458f3fab52
Cr-Commit-Position: refs/heads/master@{#411847}

Powered by Google App Engine
This is Rietveld 408576698