Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: chrome/utility/importer/bookmark_html_reader_unittest.cc

Issue 22408007: Remove "<HR>" tags to import Firefox bookmarks correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits fix and add a test case. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/utility/importer/bookmark_html_reader_unittest.cc
diff --git a/chrome/utility/importer/bookmark_html_reader_unittest.cc b/chrome/utility/importer/bookmark_html_reader_unittest.cc
index 72f42cf52bae9db26b5c65e6e7f9bc0119c8cb8f..ecdc8e9522d83642de11afdbde4ae10af1f69b72 100644
--- a/chrome/utility/importer/bookmark_html_reader_unittest.cc
+++ b/chrome/utility/importer/bookmark_html_reader_unittest.cc
@@ -196,6 +196,20 @@ TEST(BookmarkHTMLReaderTest, Firefox2BookmarkFileImport) {
ExpectThirdFirefox2Bookmark(bookmarks[2]);
}
+TEST(BookmarkHTMLReaderTest, BookmarkFileWithHrTagImport) {
+ base::FilePath path;
+ ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &path));
+ path = path.AppendASCII("bookmark_html_reader");
+ path = path.AppendASCII("firefox3.html");
+
+ std::vector<ImportedBookmarkEntry> bookmarks;
+ ImportBookmarksFile(base::Callback<bool(void)>(),
+ base::Callback<bool(const GURL&)>(),
+ path, &bookmarks, NULL);
+
+ ASSERT_EQ(7U, bookmarks.size());
gab 2013/08/09 13:27:30 Can you also verify the bookmarks' contents like t
zhchbin 2013/08/09 14:20:00 I mean to keep this test case simple and only test
gab 2013/08/09 14:29:03 Well, from knowing the implementation, we know tha
+}
+
TEST(BookmarkHTMLReaderTest, EpiphanyBookmarkFileImport) {
base::FilePath path;
ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &path));

Powered by Google App Engine
This is Rietveld 408576698