Remove "<HR>" tags to import Firefox bookmarks correctly.

chrome/utility/importer/bookmark_html_reader.cc

Index: chrome/utility/importer/bookmark_html_reader.cc
diff --git a/chrome/utility/importer/bookmark_html_reader.cc b/chrome/utility/importer/bookmark_html_reader.cc
index 5d34d7b191a817ce63ad6cf27df6cf68d6a56ce1..022aef712939f159955fc822f4da25f8c7f2b93c 100644
--- a/chrome/utility/importer/bookmark_html_reader.cc
+++ b/chrome/utility/importer/bookmark_html_reader.cc
@@ -112,6 +112,15 @@ void ImportBookmarksFile(
     std::string line;
     TrimString(lines[i], " ", &line);
 
+    // Remove "<HR>" if |line| starts with it. "<HR>" is the separator for
+    // bookmark entrys in Firefox that Chrome does not support.

[gab, 2013/08/12 14:17:41]

I would rephrase the last sentence as:

"<HR>" is the bookmark separator in Firefox that Chrome does not support

(otherwise it makes it feel like its the "bookmark entries" we don't support...)

WDYT?

[zhchbin, 2013/08/12 14:42:09]

Done.

Sorry for my poor English.

+    // See http://crbug.com/257474.
+    static const char kHrTag[] = "<HR>";
+    while (StartsWithASCII(line, kHrTag, false)) {
+      line.erase(0, arraysize(kHrTag) - 1);
+      TrimString(line, " ", &line);
+    }
+
     // Get the encoding of the bookmark file.
     if (internal::ParseCharsetFromLine(line, &charset))
       continue;