Remove "<HR>" tags to import Firefox bookmarks correctly.

chrome/utility/importer/bookmark_html_reader.cc

Index: chrome/utility/importer/bookmark_html_reader.cc
diff --git a/chrome/utility/importer/bookmark_html_reader.cc b/chrome/utility/importer/bookmark_html_reader.cc
index 5d34d7b191a817ce63ad6cf27df6cf68d6a56ce1..f8ab844a0398bc37cb238ba4b12e663897bb4124 100644
--- a/chrome/utility/importer/bookmark_html_reader.cc
+++ b/chrome/utility/importer/bookmark_html_reader.cc
@@ -111,6 +111,9 @@ void ImportBookmarksFile(
        ++i) {
     std::string line;
     TrimString(lines[i], " ", &line);

[Ilya Sherman, 2013/08/09 01:26:18]

nit: Please leave a blank line after this one.

[zhchbin, 2013/08/09 06:15:09]

Done.

+    // Remove "<HR>" if |line| starts with it. See http://crbug.com/257474.
+    if (StartsWithASCII(line, "<HR>", false))
+      TrimString(line.substr(4), " ", &line);

[Ilya Sherman, 2013/08/09 01:26:18]

Optional nit: I'd write this as follows, so that the '4' is not such a magical
constant:

const std::string kHrTag = "<HR>";
if (StartsWithASCII(line, kHrTag, false))
  TrimString(line.substr(kHrTag.size()), " ", &line);

[zhchbin, 2013/08/09 06:15:09]

Done.

 
     // Get the encoding of the bookmark file.
     if (internal::ParseCharsetFromLine(line, &charset))