Properly set loopback device ID for system audio capture.

Properly set loopback device ID for system audio capture.

Make sure the MediaStreamDevice has the correct loopback device ID for system
audio capture in MediaCaptureDevicesDispatcher::ProcessScreenCaptureAccessRequest.
Remove the hack in audio_input_renderer_host to override the loopback device ID.

BUG=269626
TBR=dalecurtis@chromium.org, xians@chromium.org
TEST=passes trybots, local testing on Chrome OS confirms device ID is passed to WebRtcLocalAudioTrack ctor.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216271

[hshi1, 2013-08-07 18:28:02]

Sergey: PTAL. I believe we need to remove the hack in audio_input_renderer_host
that detects MEDIA_SYSTEM_AUDIO_CAPTURE and overrides the loopback device_id.
Doing so only ensures that AudioInputDevice/AudioInputController gets the
device_id, but it is also needed by WebRtcAudioCapturer (as a result of the
recent code refactor by xians@).

Instead, we really need to set the device_id earlier when we first initialize
the MediaStreamDevice structure in ProcessScreenCaptureAccessRequest.

[hshi1, 2013-08-07 18:32:00]

Adding Dale as audio owner (xians@ may be offline now). Thanks!

[DaleCurtis, 2013-08-07 18:43:11]

https://codereview.chromium.org/22408006/diff/3001/chrome/browser/media/media...
File chrome/browser/media/media_capture_devices_dispatcher.cc (right):

https://codereview.chromium.org/22408006/diff/3001/chrome/browser/media/media...
chrome/browser/media/media_capture_devices_dispatcher.cc:210: bool
origin_is_secure =
const all of these bools?

https://codereview.chromium.org/22408006/diff/3001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/22408006/diff/3001/chrome/chrome_browser.gypi...
chrome/chrome_browser.gypi:12: 'use_cras%': 0,
Should this be in build/common.gypi instead?

[hshi1, 2013-08-07 18:50:24]

https://codereview.chromium.org/22408006/diff/3001/chrome/browser/media/media...
File chrome/browser/media/media_capture_devices_dispatcher.cc (right):

https://codereview.chromium.org/22408006/diff/3001/chrome/browser/media/media...
chrome/browser/media/media_capture_devices_dispatcher.cc:210: bool
origin_is_secure =
On 2013/08/07 18:43:11, DaleCurtis wrote:
> const all of these bools?

Good point, done.

https://codereview.chromium.org/22408006/diff/3001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/22408006/diff/3001/chrome/chrome_browser.gypi...
chrome/chrome_browser.gypi:12: 'use_cras%': 0,
On 2013/08/07 18:43:11, DaleCurtis wrote:
> Should this be in build/common.gypi instead?

Great suggestion! Yes I agree this should just go to common.gypi and we won't
have to worry about individual gypi's. Done.

[DaleCurtis, 2013-08-07 18:58:51]

lgtm

[commit-bot: I haz the power, 2013-08-07 19:04:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hshi@chromium.org/22408006/6002

[no longer working on chromium, 2013-08-07 19:15:45]

lgtm, thanks for fixing it.

Probably you should add browser tests to prevent breaking the system audio
capture.

https://codereview.chromium.org/22408006/diff/6002/chrome/browser/media/media...
File chrome/browser/media/media_capture_devices_dispatcher.cc (right):

https://codereview.chromium.org/22408006/diff/6002/chrome/browser/media/media...
chrome/browser/media/media_capture_devices_dispatcher.cc:264: std::string()));
It is fine to keep it this way for now.
Just a friendly reminder, all the devices are assumed to have a valid id and
name, probably one day you need to inject a valid name here.

[hshi1, 2013-08-07 19:17:39]

https://codereview.chromium.org/22408006/diff/6002/chrome/browser/media/media...
File chrome/browser/media/media_capture_devices_dispatcher.cc (right):

https://codereview.chromium.org/22408006/diff/6002/chrome/browser/media/media...
chrome/browser/media/media_capture_devices_dispatcher.cc:264: std::string()));
On 2013/08/07 19:15:45, xians1 wrote:
> It is fine to keep it this way for now.
> Just a friendly reminder, all the devices are assumed to have a valid id and
> name, probably one day you need to inject a valid name here. 

Done.

[commit-bot: I haz the power, 2013-08-07 19:17:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hshi@chromium.org/22408006/22002

[hshi1, 2013-08-07 21:02:37]

Committed patchset #5 manually as r216271 (presubmit successful).