Fix column rule under invalidation

Fix column rule under invalidation

MultiColumnSetPainter paints column rules based on style and layout data
of its parent. Thus when a multi-column container LayoutBlockFlow needs
paint invalidation it should also invalidate the child
LayoutMultiColumnSets.

BUG=635034
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/baeec3a894965c1c649f1b36035b285e240bd0c0
Cr-Commit-Position: refs/heads/master@{#411833}

[Xianzhu, 2016-08-12 17:40:47]

Description was changed from

==========
Fix column rule under invalidation

MultiColumnSetPainter paints column rules based on style and layout data
of its parent. Thus when a multi-column container LayoutBlockFlow needs
paint invalidation it should also invalidate the child
LayoutMultiColumnSets.

BUG=635034
==========

to

==========
Fix column rule under invalidation

MultiColumnSetPainter paints column rules based on style and layout data
of its parent. Thus when a multi-column container LayoutBlockFlow needs
paint invalidation it should also invalidate the child
LayoutMultiColumnSets.

BUG=635034
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-08-12 17:45:44]

wangxianzhu@chromium.org changed reviewers:
+ mstensho@opera.com

[Xianzhu, 2016-08-12 17:49:28]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 17:49:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 18:15:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 18:15:48]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mstensho (USE GERRIT), 2016-08-12 19:17:37]

lgtm

https://codereview.chromium.org/2240753003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/paint/invalidation/column-rule-change.html
(right):

https://codereview.chromium.org/2240753003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/column-rule-change.html:12:
onload = function() {
Does it really need to be inside an onload handler?

[Xianzhu, 2016-08-12 19:24:09]

https://codereview.chromium.org/2240753003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/paint/invalidation/column-rule-change.html
(right):

https://codereview.chromium.org/2240753003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/column-rule-change.html:12:
onload = function() {
On 2016/08/12 19:17:36, mstensho wrote:
> Does it really need to be inside an onload handler?

No. Removed.

(It will be necessary if the script is put before any page contents and
runAfterLayoutAndPaint may execute the function before the contents after the
script is rendered.)

[Xianzhu, 2016-08-12 19:24:12]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-08-12 19:24:12]

The patchset sent to the CQ was uploaded after l-g-t-m from mstensho@opera.com
Link to the patchset: https://codereview.chromium.org/2240753003/#ps40001
(title: "-")

[commit-bot: I haz the power, 2016-08-12 19:24:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 22:41:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 22:41:13]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2016-08-12 22:52:41]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-08-12 22:53:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 00:38:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-13 00:40:15]

Description was changed from

==========
Fix column rule under invalidation

MultiColumnSetPainter paints column rules based on style and layout data
of its parent. Thus when a multi-column container LayoutBlockFlow needs
paint invalidation it should also invalidate the child
LayoutMultiColumnSets.

BUG=635034
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix column rule under invalidation

MultiColumnSetPainter paints column rules based on style and layout data
of its parent. Thus when a multi-column container LayoutBlockFlow needs
paint invalidation it should also invalidate the child
LayoutMultiColumnSets.

BUG=635034
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/baeec3a894965c1c649f1b36035b285e240bd0c0
Cr-Commit-Position: refs/heads/master@{#411833}
==========

[commit-bot: I haz the power, 2016-08-13 00:40:16]

Patchset 3 (id:??) landed as
https://crrev.com/baeec3a894965c1c649f1b36035b285e240bd0c0
Cr-Commit-Position: refs/heads/master@{#411833}