Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2240673003:
Remove obsolete "link_pool" code from GN's ninja writer. (Closed)
DescriptionRemove obsolete "link_pool" code from GN's ninja writer.
The default "link_pool" was removed when code was refactored to use
explicit pool, but this code was forgotten. It is now dead, removing.
BUG=612786
Committed: https://crrev.com/7d1c95f62081964bdfbce57f05ec226918a2d940
Cr-Commit-Position: refs/heads/master@{#411735}
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
sdefresne@chromium.org changed reviewers: + brettw@chromium.org
Please take a look and send to CQ if lgty.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
Description was changed from ========== Remove obsolete code. The default "link_pool" was removed when code was refactored to use explicit pool, but this code was forgotten. It is now dead, removing. BUG=612786 ========== to ========== Remove obsolete "link_pool" code from GN's ninja writer. The default "link_pool" was removed when code was refactored to use explicit pool, but this code was forgotten. It is now dead, removing. BUG=612786 ==========
I edited the subject and description a bit ...
lgtm
On 2016/08/11 22:56:51, Dirk Pranke (slow) wrote: > I edited the subject and description a bit ... Looks good to me, thank you.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove obsolete "link_pool" code from GN's ninja writer. The default "link_pool" was removed when code was refactored to use explicit pool, but this code was forgotten. It is now dead, removing. BUG=612786 ========== to ========== Remove obsolete "link_pool" code from GN's ninja writer. The default "link_pool" was removed when code was refactored to use explicit pool, but this code was forgotten. It is now dead, removing. BUG=612786 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove obsolete "link_pool" code from GN's ninja writer. The default "link_pool" was removed when code was refactored to use explicit pool, but this code was forgotten. It is now dead, removing. BUG=612786 ========== to ========== Remove obsolete "link_pool" code from GN's ninja writer. The default "link_pool" was removed when code was refactored to use explicit pool, but this code was forgotten. It is now dead, removing. BUG=612786 Committed: https://crrev.com/7d1c95f62081964bdfbce57f05ec226918a2d940 Cr-Commit-Position: refs/heads/master@{#411735} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7d1c95f62081964bdfbce57f05ec226918a2d940 Cr-Commit-Position: refs/heads/master@{#411735} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
