Only open X Display once for all test GLX contexts

Only open X Display once for all test GLX contexts

Saves about 4 seconds of runtime for 'dm --src gm --config gpu' on my system.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240673002

Committed: https://skia.googlesource.com/skia/+/300178b1c83e7a9b8d3bee7aeb09e0d4fb096d6b

[bsalomon, 2016-08-11 21:14:44]

Description was changed from

==========
Only open X Display once for all test GLX contexts
==========

to

==========
Only open X Display once for all test GLX contexts
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240673002
==========

[bsalomon, 2016-08-11 21:15:28]

Description was changed from

==========
Only open X Display once for all test GLX contexts
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240673002
==========

to

==========
Only open X Display once for all test GLX contexts

Saves about 4 seconds of runtime for 'dm --src gm --config gpu' on my system.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240673002
==========

[bsalomon, 2016-08-11 21:15:28]

bsalomon@google.com changed reviewers:
+ csmartdalton@google.com

[csmartdalton, 2016-08-11 21:29:05]

lgtm

https://codereview.chromium.org/2240673002/diff/1/tools/gpu/gl/glx/CreatePlat...
File tools/gpu/gl/glx/CreatePlatformGLTestContext_glx.cpp (right):

https://codereview.chromium.org/2240673002/diff/1/tools/gpu/gl/glx/CreatePlat...
tools/gpu/gl/glx/CreatePlatformGLTestContext_glx.cpp:80:
XCloseDisplay(fDisplay);
This might not be necessary, I'd imagine it would get cleaned up upon process
exit anyway?

[bsalomon, 2016-08-11 21:32:40]

On 2016/08/11 21:29:05, csmartdalton wrote:
> lgtm
> 
>
https://codereview.chromium.org/2240673002/diff/1/tools/gpu/gl/glx/CreatePlat...
> File tools/gpu/gl/glx/CreatePlatformGLTestContext_glx.cpp (right):
> 
>
https://codereview.chromium.org/2240673002/diff/1/tools/gpu/gl/glx/CreatePlat...
> tools/gpu/gl/glx/CreatePlatformGLTestContext_glx.cpp:80:
> XCloseDisplay(fDisplay);
> This might not be necessary, I'd imagine it would get cleaned up upon process
> exit anyway?

Probably.. but just wanted to protect against any issues on valgrind/*san bots.

[bsalomon, 2016-08-11 21:33:10]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-08-11 21:33:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 21:58:39]

Description was changed from

==========
Only open X Display once for all test GLX contexts

Saves about 4 seconds of runtime for 'dm --src gm --config gpu' on my system.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240673002
==========

to

==========
Only open X Display once for all test GLX contexts

Saves about 4 seconds of runtime for 'dm --src gm --config gpu' on my system.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240673002

Committed:
https://skia.googlesource.com/skia/+/300178b1c83e7a9b8d3bee7aeb09e0d4fb096d6b
==========

[commit-bot: I haz the power, 2016-08-11 21:58:39]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/300178b1c83e7a9b8d3bee7aeb09e0d4fb096d6b